[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-windows
Subject: Re: Review Request 127672: declare s_pulseActive outside HAVE_PULSEAUDIO ifdef
From: Andrius da Costa Ribas <andriusmao () gmail ! com>
Date: 2016-04-17 19:27:14
Message-ID: 20160417192714.10515.33715 () mimi ! kde ! org
[Download RAW message or body]
--===============7394868693922972781==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127672/
-----------------------------------------------------------
(Updated April 17, 2016, 7:27 p.m.)
Status
------
This change has been marked as submitted.
Review request for kdewin and Phonon.
Changes
-------
Submitted with commit 92adeaf2851a1f94ea3b3cdfdf3e6b27394d2a53 by Andrius da Costa \
Ribas to branch master.
Repository: phonon
Description
-------
s_pulseActive is used inside PulseSupport::isUsable but is declared under \
HAVE_PULSEAUDIO ifdef. Another solution would be creating an ifdef inside this method \
to always return false when we don't HAVE_PULSEAUDIO.
Diffs
-----
phonon/pulsesupport.cpp dd79204
Diff: https://git.reviewboard.kde.org/r/127672/diff/
Testing
-------
It builds on windows after this patch, no further testing done.
Thanks,
Andrius da Costa Ribas
--===============7394868693922972781==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127672/">https://git.reviewboard.kde.org/r/127672/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdewin and Phonon.</div>
<div>By Andrius da Costa Ribas.</div>
<p style="color: grey;"><i>Updated April 17, 2016, 7:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 92adeaf2851a1f94ea3b3cdfdf3e6b27394d2a53 by \
Andrius da Costa Ribas to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
phonon
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">s_pulseActive is used inside PulseSupport::isUsable \
but is declared under HAVE_PULSEAUDIO ifdef. Another solution would be creating an \
ifdef inside this method to always return false when we don't \
HAVE_PULSEAUDIO.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It builds on windows after this patch, no further \
testing done.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>phonon/pulsesupport.cpp <span style="color: grey">(dd79204)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127672/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7394868693922972781==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic