'Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-windows
Subject:    Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows
From:       Dominik Haumann <dhaumann () kde ! org>
Date:       2016-03-25 16:43:00
Message-ID: 20160325164300.21226.16967 () mimi ! kde ! org
[Download RAW message or body]

--===============6690620494355612810==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/
-----------------------------------------------------------

(Updated March 25, 2016, 9:43 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks, kdewin, kwin, and Marco Martin.

Changes
-------

Submitted with commit 906e6a1409389c5abc501f0172c5dff21fdc6edd by Dominik Haumann to \
branch master.

Repository: kcompletion

Description
-------

In https://git.reviewboard.kde.org/r/127191/ the KCompletionBox WindowFlags were \
change from Qt::ToolTip to Qt::Window.

As consequence, the completion popup of the Kate command line gets a full window \
decoration, which is obviously wrong, see attached screenshot.

Changing the type to Qt::Popup shows the proper popup, but key presses are not \
forwarded, so typing is not possible, and additionally, on losing focus the popup \
keeps staying open. Therefore, this patch reverts the type back to Qt::ToolTip.

Better fixes are of course welcome ;) Any ideas?

Diffs
-----

  src/kcompletionbox.cpp 005aff8 

Diff: https://git.reviewboard.kde.org/r/127424/diff/

Testing
-------

Works on Windows as expected.

File Attachments
----------------

Completion Popup
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png

Thanks,

Dominik Haumann

--===============6690620494355612810==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127424/">https://git.reviewboard.kde.org/r/127424/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, kdewin, kwin, and Marco Martin.</div>
<div>By Dominik Haumann.</div>

<p style="color: grey;"><i>Updated March 25, 2016, 9:43 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 906e6a1409389c5abc501f0172c5dff21fdc6edd by \
Dominik Haumann to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kcompletion
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In https://git.reviewboard.kde.org/r/127191/ the \
KCompletionBox WindowFlags were change from Qt::ToolTip to Qt::Window.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">As consequence, the completion popup of the Kate command line gets a full \
window decoration, which is obviously wrong, see attached screenshot.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Changing the type to Qt::Popup shows the proper popup, but key presses are \
not forwarded, so typing is not possible, and additionally, on losing focus the popup \
keeps staying open. Therefore, this patch reverts the type back to Qt::ToolTip.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Better fixes are of course welcome ;) Any \
ideas?</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works on Windows as expected.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kcompletionbox.cpp <span style="color: grey">(005aff8)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127424/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png">Completion \
Popup</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6690620494355612810==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

[prev in list] [next in list] [prev in thread] [next in thread] 