From kde-windows Sat Jan 30 15:58:01 2016 From: Patrick Spendrin Date: Sat, 30 Jan 2016 15:58:01 +0000 To: kde-windows Subject: Re: Review Request 126375: Remove kdelibs4support from the generator plugins Message-Id: <20160130155801.17778.76873 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-windows&m=145416951612260 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2088365426387995944==" --===============2088365426387995944== Content-Type: multipart/alternative; boundary="===============7457892492981926561==" --===============7457892492981926561== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126375/ ----------------------------------------------------------- (Updated Jan. 30, 2016, 4:58 p.m.) Status ------ This change has been marked as submitted. Review request for kdewin and Okular. Changes ------- Submitted with commit 37d562310266a85b21896cbe8ab333f0e7f680d5 by Aleix Pol on behalf of Patrick Spendrin to branch frameworks. Repository: okular Description ------- This removes kdelibs4support for all generators except the mobipocket one. The test executable for kimgio needs some windows fixes too, so I'll try to make a separate review for that. Diffs ----- CMakeLists.txt 72ff3e8754a9005dd09cf49e83d67b0a4f9258db generators/comicbook/CMakeLists.txt 684613b5bd756696eff79b52f0e184588f19f3d5 generators/comicbook/unrar.cpp 6290919286ee7c2fa8d64599aae44915750a2606 generators/djvu/CMakeLists.txt 34dc1a139eaae868464fb158a35408000ffc2ed7 generators/djvu/generator_djvu.cpp 740e38c665b7f3a0d174b56c2fbe2bbc5fb5cfe0 generators/djvu/kdjvu.cpp 3a5b29e6869222ff94c503d6bc46e736b24e7f60 generators/dvi/CMakeLists.txt 38f321a1118f68027a2e1e365f79ee607f67bfe7 generators/dvi/pageSize.cpp fefedd5a5de843c47abba15162b9835848119f38 generators/epub/CMakeLists.txt 41ecd23a4d04997aef297f190da8f1b06e0732d8 generators/kimgio/CMakeLists.txt 5d9011b02ae76daac6b98e390b13857837dd9bc4 generators/kimgio/generator_kimgio.cpp 84c155b5ad8da5057a28faaffa417ecb60a64ab3 generators/ooo/CMakeLists.txt eb6f63ca00c898c437c40c68466795b2b8f70f64 generators/ooo/styleparser.cpp 0547b84b13287591ea5248d47065dbf925524fb1 generators/poppler/CMakeLists.txt a696ffbb8218abb8094afbc0db1b249bc2d9c3c8 generators/poppler/generator_pdf.cpp 90db80a41ecef76733ab79ebc41c162725cf30ed generators/spectre/CMakeLists.txt d7eb0e28d4d15072e0c118dd79b005d8ac9ea9c1 generators/tiff/CMakeLists.txt 89603085fef5fdfd135f04e1d4f0026772a663b0 generators/tiff/generator_tiff.cpp cf4f2762a506a07288bb6fb1169ddbceb5a5eccb ui/guiutils.cpp 379d1e625e7b77a870ed04258a3fe1de3aadeb91 ui/pagepainter.cpp 0c8443cc93c0d81e0cf92a7f5bd9ac3c79a0fb3a Diff: https://git.reviewboard.kde.org/r/126375/diff/ Testing ------- Windows. Thanks, Patrick Spendrin --===============7457892492981926561== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126375/

This change has been marked as submitted.

Review request for kdewin and Okular.
By Patrick Spendrin.

Updated Jan. 30, 2016, 4:58 p.m.

Changes

Submitted with commit 37d562310266a85b21896cbe8ab333f0e7f680d5 by Aleix Pol on behalf of Patrick Spendrin to branch frameworks.
Repository: okular

Description 

This removes kdelibs4support for all generators except the mobipocket one.
The test executable for kimgio needs some windows fixes too, so I'll try
to make a separate review for that.

Testing 

Windows.

Diffs

  • CMakeLists.txt (72ff3e8754a9005dd09cf49e83d67b0a4f9258db)
  • generators/comicbook/CMakeLists.txt (684613b5bd756696eff79b52f0e184588f19f3d5)
  • generators/comicbook/unrar.cpp (6290919286ee7c2fa8d64599aae44915750a2606)
  • generators/djvu/CMakeLists.txt (34dc1a139eaae868464fb158a35408000ffc2ed7)
  • generators/djvu/generator_djvu.cpp (740e38c665b7f3a0d174b56c2fbe2bbc5fb5cfe0)
  • generators/djvu/kdjvu.cpp (3a5b29e6869222ff94c503d6bc46e736b24e7f60)
  • generators/dvi/CMakeLists.txt (38f321a1118f68027a2e1e365f79ee607f67bfe7)
  • generators/dvi/pageSize.cpp (fefedd5a5de843c47abba15162b9835848119f38)
  • generators/epub/CMakeLists.txt (41ecd23a4d04997aef297f190da8f1b06e0732d8)
  • generators/kimgio/CMakeLists.txt (5d9011b02ae76daac6b98e390b13857837dd9bc4)
  • generators/kimgio/generator_kimgio.cpp (84c155b5ad8da5057a28faaffa417ecb60a64ab3)
  • generators/ooo/CMakeLists.txt (eb6f63ca00c898c437c40c68466795b2b8f70f64)
  • generators/ooo/styleparser.cpp (0547b84b13287591ea5248d47065dbf925524fb1)
  • generators/poppler/CMakeLists.txt (a696ffbb8218abb8094afbc0db1b249bc2d9c3c8)
  • generators/poppler/generator_pdf.cpp (90db80a41ecef76733ab79ebc41c162725cf30ed)
  • generators/spectre/CMakeLists.txt (d7eb0e28d4d15072e0c118dd79b005d8ac9ea9c1)
  • generators/tiff/CMakeLists.txt (89603085fef5fdfd135f04e1d4f0026772a663b0)
  • generators/tiff/generator_tiff.cpp (cf4f2762a506a07288bb6fb1169ddbceb5a5eccb)
  • ui/guiutils.cpp (379d1e625e7b77a870ed04258a3fe1de3aadeb91)
  • ui/pagepainter.cpp (0c8443cc93c0d81e0cf92a7f5bd9ac3c79a0fb3a)

View Diff
--===============7457892492981926561==-- --===============2088365426387995944== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KS2RlLXdpbmRv d3MgbWFpbGluZyBsaXN0CktkZS13aW5kb3dzQGtkZS5vcmcKaHR0cHM6Ly9tYWlsLmtkZS5vcmcv bWFpbG1hbi9saXN0aW5mby9rZGUtd2luZG93cwo= --===============2088365426387995944==--