[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-windows
Subject: Re: Review Request 126375: Remove kdelibs4support from the generator plugins
From: "Patrick Spendrin" <ps_ml () gmx ! de>
Date: 2015-12-16 22:25:43
Message-ID: 20151216222543.7434.90192 () mimi ! kde ! org
[Download RAW message or body]
--===============2322532329740528382==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dez. 16, 2015, 4:42 nachm., Alex Richardson wrote:
> > generators/djvu/kdjvu.cpp, line 39
> > <https://git.reviewboard.kde.org/r/126375/diff/1/?file=422860#file422860line39>
> >
> > Use qCDebug() together with ecm_qt_declare_logging_category() ?
Yes, I only saw that after the review was opened, I'll adapt this to the way the \
other generators handle it.
- Patrick
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126375/#review89607
-----------------------------------------------------------
On Dez. 16, 2015, 12:41 vorm., Patrick Spendrin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126375/
> -----------------------------------------------------------
>
> (Updated Dez. 16, 2015, 12:41 vorm.)
>
>
> Review request for kdewin and Okular.
>
>
> Repository: okular
>
>
> Description
> -------
>
> This removes kdelibs4support for all generators except the mobipocket one.
> The test executable for kimgio needs some windows fixes too, so I'll try
> to make a separate review for that.
>
>
> Diffs
> -----
>
> CMakeLists.txt 72ff3e8754a9005dd09cf49e83d67b0a4f9258db
> generators/comicbook/CMakeLists.txt 684613b5bd756696eff79b52f0e184588f19f3d5
> generators/comicbook/unrar.cpp 6290919286ee7c2fa8d64599aae44915750a2606
> generators/djvu/CMakeLists.txt 34dc1a139eaae868464fb158a35408000ffc2ed7
> generators/djvu/generator_djvu.cpp 740e38c665b7f3a0d174b56c2fbe2bbc5fb5cfe0
> generators/djvu/kdjvu.cpp 3a5b29e6869222ff94c503d6bc46e736b24e7f60
> generators/dvi/CMakeLists.txt 38f321a1118f68027a2e1e365f79ee607f67bfe7
> generators/dvi/pageSize.cpp fefedd5a5de843c47abba15162b9835848119f38
> generators/epub/CMakeLists.txt 41ecd23a4d04997aef297f190da8f1b06e0732d8
> generators/kimgio/CMakeLists.txt 5d9011b02ae76daac6b98e390b13857837dd9bc4
> generators/kimgio/generator_kimgio.cpp 84c155b5ad8da5057a28faaffa417ecb60a64ab3
> generators/ooo/CMakeLists.txt eb6f63ca00c898c437c40c68466795b2b8f70f64
> generators/ooo/styleparser.cpp 0547b84b13287591ea5248d47065dbf925524fb1
> generators/poppler/CMakeLists.txt a696ffbb8218abb8094afbc0db1b249bc2d9c3c8
> generators/poppler/generator_pdf.cpp 90db80a41ecef76733ab79ebc41c162725cf30ed
> generators/spectre/CMakeLists.txt d7eb0e28d4d15072e0c118dd79b005d8ac9ea9c1
> generators/tiff/CMakeLists.txt 89603085fef5fdfd135f04e1d4f0026772a663b0
> generators/tiff/generator_tiff.cpp cf4f2762a506a07288bb6fb1169ddbceb5a5eccb
> ui/guiutils.cpp 379d1e625e7b77a870ed04258a3fe1de3aadeb91
> ui/pagepainter.cpp 0c8443cc93c0d81e0cf92a7f5bd9ac3c79a0fb3a
>
> Diff: https://git.reviewboard.kde.org/r/126375/diff/
>
>
> Testing
> -------
>
> Windows.
>
>
> Thanks,
>
> Patrick Spendrin
>
>
--===============2322532329740528382==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126375/">https://git.reviewboard.kde.org/r/126375/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Dezember 16th, 2015, 4:42 nachm. UTC, <b>Alex \
Richardson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126375/diff/1/?file=422860#file422860line39" \
style="color: black; font-weight: bold; text-decoration: \
underline;">generators/djvu/kdjvu.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">39</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span \
class="hl">k</span>Debug</span><span class="p">()</span> <span \
class="o"><<</span> <span class="s">"which_djvu_message(...):"</span> \
<span class="o"><<</span> <span class="n">msg</span><span \
class="o">-></span><span class="n">m_any</span><span class="p">.</span><span \
class="n">tag</span><span class="p">;</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">38</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span \
class="hl">q</span>Debug</span><span class="p">()</span> <span \
class="o"><<</span> <span class="s">"which_djvu_message(...):"</span> \
<span class="o"><<</span> <span class="n">msg</span><span \
class="o">-></span><span class="n">m_any</span><span class="p">.</span><span \
class="n">tag</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use \
qCDebug() together with ecm_qt_declare_logging_category() ?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Yes, I only saw that after the review was opened, I'll adapt this to the \
way the other generators handle it.</p></pre> <br />
<p>- Patrick</p>
<br />
<p>On Dezember 16th, 2015, 12:41 vorm. UTC, Patrick Spendrin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdewin and Okular.</div>
<div>By Patrick Spendrin.</div>
<p style="color: grey;"><i>Updated Dez. 16, 2015, 12:41 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This removes kdelibs4support for all generators except the mobipocket \
one. The test executable for kimgio needs some windows fixes too, so I'll try
to make a separate review for that.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Windows.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(72ff3e8754a9005dd09cf49e83d67b0a4f9258db)</span></li>
<li>generators/comicbook/CMakeLists.txt <span style="color: \
grey">(684613b5bd756696eff79b52f0e184588f19f3d5)</span></li>
<li>generators/comicbook/unrar.cpp <span style="color: \
grey">(6290919286ee7c2fa8d64599aae44915750a2606)</span></li>
<li>generators/djvu/CMakeLists.txt <span style="color: \
grey">(34dc1a139eaae868464fb158a35408000ffc2ed7)</span></li>
<li>generators/djvu/generator_djvu.cpp <span style="color: \
grey">(740e38c665b7f3a0d174b56c2fbe2bbc5fb5cfe0)</span></li>
<li>generators/djvu/kdjvu.cpp <span style="color: \
grey">(3a5b29e6869222ff94c503d6bc46e736b24e7f60)</span></li>
<li>generators/dvi/CMakeLists.txt <span style="color: \
grey">(38f321a1118f68027a2e1e365f79ee607f67bfe7)</span></li>
<li>generators/dvi/pageSize.cpp <span style="color: \
grey">(fefedd5a5de843c47abba15162b9835848119f38)</span></li>
<li>generators/epub/CMakeLists.txt <span style="color: \
grey">(41ecd23a4d04997aef297f190da8f1b06e0732d8)</span></li>
<li>generators/kimgio/CMakeLists.txt <span style="color: \
grey">(5d9011b02ae76daac6b98e390b13857837dd9bc4)</span></li>
<li>generators/kimgio/generator_kimgio.cpp <span style="color: \
grey">(84c155b5ad8da5057a28faaffa417ecb60a64ab3)</span></li>
<li>generators/ooo/CMakeLists.txt <span style="color: \
grey">(eb6f63ca00c898c437c40c68466795b2b8f70f64)</span></li>
<li>generators/ooo/styleparser.cpp <span style="color: \
grey">(0547b84b13287591ea5248d47065dbf925524fb1)</span></li>
<li>generators/poppler/CMakeLists.txt <span style="color: \
grey">(a696ffbb8218abb8094afbc0db1b249bc2d9c3c8)</span></li>
<li>generators/poppler/generator_pdf.cpp <span style="color: \
grey">(90db80a41ecef76733ab79ebc41c162725cf30ed)</span></li>
<li>generators/spectre/CMakeLists.txt <span style="color: \
grey">(d7eb0e28d4d15072e0c118dd79b005d8ac9ea9c1)</span></li>
<li>generators/tiff/CMakeLists.txt <span style="color: \
grey">(89603085fef5fdfd135f04e1d4f0026772a663b0)</span></li>
<li>generators/tiff/generator_tiff.cpp <span style="color: \
grey">(cf4f2762a506a07288bb6fb1169ddbceb5a5eccb)</span></li>
<li>ui/guiutils.cpp <span style="color: \
grey">(379d1e625e7b77a870ed04258a3fe1de3aadeb91)</span></li>
<li>ui/pagepainter.cpp <span style="color: \
grey">(0c8443cc93c0d81e0cf92a7f5bd9ac3c79a0fb3a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126375/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2322532329740528382==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic