[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-windows
Subject: Re: Review Request 126378: remove kactivities on windows
From: "Alex Richardson" <arichardson.kde () gmail ! com>
Date: 2015-12-16 16:45:08
Message-ID: 20151216164508.7434.42558 () mimi ! kde ! org
[Download RAW message or body]
--===============1345581362459239698==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126378/#review89610
-----------------------------------------------------------
shell/shell.cpp (line 48)
<https://git.reviewboard.kde.org/r/126378/#comment61352>
`#if HAVE_KACTIVITIES` would be nicer and then KActivities could just be turned \
into an optional dependency which wouldn't be found on Windows?
I prefer having ifdefs based on available features rather than hardcoded on the \
OS
- Alex Richardson
On Dec. 16, 2015, 1:16 a.m., Patrick Spendrin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126378/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 1:16 a.m.)
>
>
> Review request for kdewin and Okular.
>
>
> Repository: okular
>
>
> Description
> -------
>
> KActivities is not used on Windows, so a hard dependency on it
> only brings unneeded code.
> This patch removes it completely under Windows.
>
>
> Diffs
> -----
>
> CMakeLists.txt 72ff3e8754a9005dd09cf49e83d67b0a4f9258db
> shell/CMakeLists.txt 7a6af745464fe7bb1d6702cc02787e7e6d4c101e
> shell/shell.cpp e69ecbb5e1bde36dbd00e5ff05cdad4e3d2a5f8d
>
> Diff: https://git.reviewboard.kde.org/r/126378/diff/
>
>
> Testing
> -------
>
> Windows.
>
>
> Thanks,
>
> Patrick Spendrin
>
>
--===============1345581362459239698==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126378/">https://git.reviewboard.kde.org/r/126378/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126378/diff/1/?file=423785#file423785line48" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shell/shell.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">48</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#ifndef Q_OS_WIN</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">#if HAVE_KACTIVITIES</code> would be nicer and then \
KActivities could just be turned into an optional dependency which wouldn't be found \
on Windows?</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I prefer having ifdefs based on available features \
rather than hardcoded on the OS</p></pre> </div>
</div>
<br />
<p>- Alex Richardson</p>
<br />
<p>On December 16th, 2015, 1:16 a.m. GMT, Patrick Spendrin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdewin and Okular.</div>
<div>By Patrick Spendrin.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2015, 1:16 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KActivities is not used on Windows, so a hard dependency on it only \
brings unneeded code. This patch removes it completely under Windows.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Windows.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(72ff3e8754a9005dd09cf49e83d67b0a4f9258db)</span></li>
<li>shell/CMakeLists.txt <span style="color: \
grey">(7a6af745464fe7bb1d6702cc02787e7e6d4c101e)</span></li>
<li>shell/shell.cpp <span style="color: \
grey">(e69ecbb5e1bde36dbd00e5ff05cdad4e3d2a5f8d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126378/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1345581362459239698==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic