[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-windows
Subject: Re: Review Request 125580: Make qt-libs/poppler compile with MSVC 2015.
From: "Christian Ehrlicher" <ch.ehrlicher () gmx ! de>
Date: 2015-10-11 14:44:16
Message-ID: 20151011144416.23606.1731 () mimi ! kde ! org
[Download RAW message or body]
--===============7848931677481675502==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125580/#review86661
-----------------------------------------------------------
portage/qt-libs/poppler/poppler-0.35.0-20151007.diff (lines 20 - 22)
<https://git.reviewboard.kde.org/r/125580/#comment59654>
Why do you guard it with '_MSC_VER >= 1900' here? The guard should be removed or \
added everywhere else. btw: The same patches are needed for msvc2013 too, so the \
guard should be at least '_MSC_VER >= 1800' for upstream
- Christian Ehrlicher
On Okt. 11, 2015, 1:39 nachm., Gleb Popov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125580/
> -----------------------------------------------------------
>
> (Updated Okt. 11, 2015, 1:39 nachm.)
>
>
> Review request for kdewin, Albert Astals Cid and Pino Toscano.
>
>
> Repository: emerge
>
>
> Description
> -------
>
> I've had to put #include <algorithm> everywhere, not sure if it is a right thing to \
> do.
>
> Diffs
> -----
>
> portage/qt-libs/poppler/poppler-0.35.0-20151007.diff PRE-CREATION
> portage/qt-libs/poppler/poppler.py e26d35a
>
> Diff: https://git.reviewboard.kde.org/r/125580/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gleb Popov
>
>
--===============7848931677481675502==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125580/">https://git.reviewboard.kde.org/r/125580/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125580/diff/2/?file=410562#file410562line20" \
style="color: black; font-weight: bold; text-decoration: \
underline;">portage/qt-libs/poppler/poppler-0.35.0-20151007.diff</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">20</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="gi">+#if _MSC_VER >= 1900</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">21</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="gi">+#include <algorithm></span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">22</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="gi">+#else</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why \
do you guard it with '_MSC_VER >= 1900' here? The guard should be removed or added \
everywhere else.
btw: The same patches are needed for msvc2013 too, so the guard should be at least \
'_MSC_VER >= 1800' for upstream</p></pre> </div>
</div>
<br />
<p>- Christian Ehrlicher</p>
<br />
<p>On Oktober 11th, 2015, 1:39 nachm. UTC, Gleb Popov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdewin, Albert Astals Cid and Pino Toscano.</div>
<div>By Gleb Popov.</div>
<p style="color: grey;"><i>Updated Okt. 11, 2015, 1:39 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
emerge
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I've had to put #include <algorithm> everywhere, \
not sure if it is a right thing to do.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>portage/qt-libs/poppler/poppler-0.35.0-20151007.diff <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>portage/qt-libs/poppler/poppler.py <span style="color: \
grey">(e26d35a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125580/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7848931677481675502==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic