[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-windows
Subject: Re: Review Request 117829: do not raise unknown signal on windows
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2015-02-04 16:09:47
Message-ID: 20150204160947.19248.44517 () probe ! kde ! org
[Download RAW message or body]
--===============4392476792527070719==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On April 28, 2014, 12:42 p.m., Vishesh Handa wrote:
> > src/file/autotest/fileindexingjob/extractor.cpp, line 76
> > <https://git.reviewboard.kde.org/r/117829/diff/1/?file=268894#file268894line76>
> >
> > Wouldn't exit just terminate the process normally? I was hoping to simulate a \
> > crash.
>
> Michael Pyne wrote:
> If you want to simulate a crash portably, you might want to try abort(3), which is \
> available in C since C89. I'm not sure what it does on Windows, but on POSIX it \
> throws SIGABRT instead but that should be easy enough to adjust to.
> Vishesh Handa wrote:
> ping?
>
> Vishesh Handa wrote:
> ping?
I'm closing this review for now. Please feel free to re-open it or file a new one.
- Vishesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117829/#review56738
-----------------------------------------------------------
On April 28, 2014, 9:54 a.m., Patrick Spendrin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117829/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 9:54 a.m.)
>
>
> Review request for Baloo and kdewin.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> this signal is not available on windows. Also exit should behave in a similar way, \
> so maybe exit can be used everywhere?
>
> Diffs
> -----
>
> src/file/autotest/fileindexingjob/extractor.cpp a6d14d7
>
> Diff: https://git.reviewboard.kde.org/r/117829/diff/
>
>
> Testing
> -------
>
> windows msvc 2010
>
>
> Thanks,
>
> Patrick Spendrin
>
>
--===============4392476792527070719==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117829/">https://git.reviewboard.kde.org/r/117829/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 28th, 2014, 12:42 p.m. UTC, <b>Vishesh \
Handa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/117829/diff/1/?file=268894#file268894line76" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/file/autotest/fileindexingjob/extractor.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
main(int argc, char* argv[])</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">76</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">exit</span><span class="p">(</span><span class="o">-</span><span \
class="mi">1</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wouldn't exit just \
terminate the process normally? I was hoping to simulate a crash.</pre> \
</blockquote>
<p>On April 29th, 2014, 10:55 p.m. UTC, <b>Michael Pyne</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you want to simulate \
a crash portably, you might want to try abort(3), which is available in C since C89. \
I'm not sure what it does on Windows, but on POSIX it throws SIGABRT instead but \
that should be easy enough to adjust to.</pre> </blockquote>
<p>On July 7th, 2014, 9:54 a.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">ping?</p></pre> </blockquote>
<p>On October 17th, 2014, 3:30 p.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">ping?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I'm closing this review for now. Please feel free to re-open it or file a \
new one.</p></pre> <br />
<p>- Vishesh</p>
<br />
<p>On April 28th, 2014, 9:54 a.m. UTC, Patrick Spendrin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo and kdewin.</div>
<div>By Patrick Spendrin.</div>
<p style="color: grey;"><i>Updated April 28, 2014, 9:54 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this signal is not available on windows. Also exit should behave in a \
similar way, so maybe exit can be used everywhere?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">windows msvc 2010</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/file/autotest/fileindexingjob/extractor.cpp <span style="color: \
grey">(a6d14d7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117829/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4392476792527070719==--
_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic