[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-windows
Subject: Re: Review Request 122177: some minor fixes for windows
From: "Allen Winter" <winter () kde ! org>
Date: 2015-01-20 23:05:02
Message-ID: 20150120230502.32442.21135 () probe ! kde ! org
[Download RAW message or body]
--===============3544292454459998123==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122177/#review74449
-----------------------------------------------------------
src/runtime/main.cpp
<https://git.reviewboard.kde.org/r/122177/#comment51638>
yes, if you want to delete SESSION_MANAGER completely from the environment then \
use qunsetenv(). qunsetenv() is new since Qt 5.1.
you don't need the conditional compile now.
- Allen Winter
On Jan. 20, 2015, 9:11 p.m., Patrick Spendrin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122177/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2015, 9:11 p.m.)
>
>
> Review request for KDE Frameworks and kdewin.
>
>
> Repository: kglobalaccel
>
>
> Description
> -------
>
> some minor fixes for windows
>
>
> Diffs
> -----
>
> src/runtime/CMakeLists.txt a8fbfa1612a86f7371bf56926ec46fe14422a73a
> src/runtime/main.cpp f9cf9b353f00f1f68906d97f61cea5314a3663e4
>
> Diff: https://git.reviewboard.kde.org/r/122177/diff/
>
>
> Testing
> -------
>
> windows msvc 2013
>
>
> Thanks,
>
> Patrick Spendrin
>
>
--===============3544292454459998123==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122177/">https://git.reviewboard.kde.org/r/122177/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122177/diff/1/?file=343911#file343911line56" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/runtime/main.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">extern \
"C" Q_DECL_EXPORT int main(int argc, char **argv)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">56</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#ifndef Q_OS_WIN</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yes, \
if you want to delete SESSION_MANAGER completely from the environment then use \
qunsetenv(). qunsetenv() is new since Qt 5.1.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">you \
don't need the conditional compile now.</p></pre> </div>
</div>
<br />
<p>- Allen Winter</p>
<br />
<p>On January 20th, 2015, 9:11 p.m. UTC, Patrick Spendrin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and kdewin.</div>
<div>By Patrick Spendrin.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2015, 9:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kglobalaccel
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">some minor fixes for windows</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">windows msvc 2013</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/runtime/CMakeLists.txt <span style="color: \
grey">(a8fbfa1612a86f7371bf56926ec46fe14422a73a)</span></li>
<li>src/runtime/main.cpp <span style="color: \
grey">(f9cf9b353f00f1f68906d97f61cea5314a3663e4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122177/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3544292454459998123==--
_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic