[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-windows
Subject: Re: Review Request 120877: Convert switch statements to if/else due to MSVC limitation
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2014-10-29 9:25:33
Message-ID: 20141029092533.23656.35249 () probe ! kde ! org
[Download RAW message or body]
--===============6694764946154471683==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120877/#review69384
-----------------------------------------------------------
No opinion on the patch but please check your coding style.
src/plasma/private/framesvg_helpers.h
<https://git.reviewboard.kde.org/r/120877/#comment48486>
Always put the brace on the same line as the else if
- Kai Uwe Broulik
On Okt. 29, 2014, 2:09 vorm., Andrius da Costa Ribas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120877/
> -----------------------------------------------------------
>
> (Updated Okt. 29, 2014, 2:09 vorm.)
>
>
> Review request for kdewin and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> MSVC is unable to recognise e.g. FrameSvg::TopBorder | FrameSvg::LeftBorder as a \
> compile-time const expression (error C2051: case expression not constant)
>
> Diffs
> -----
>
> src/plasma/private/framesvg_helpers.h 5b96cd5
>
> Diff: https://git.reviewboard.kde.org/r/120877/diff/
>
>
> Testing
> -------
>
> Builds with MSVC 2013 64bit.
>
> framesvg related tests pass, other unrelated tests still fail.
>
> Test project V:/build/frameworks/plasma/work/msvc2013-RelWithDebInfo-master
> Start 1: plasma-dialogqmltest
> 1/10 Test #1: plasma-dialogqmltest ...............***Failed 1.15 sec
> Start 2: plasma-fallbackpackagetest
> 2/10 Test #2: plasma-fallbackpackagetest ......... Passed 0.16 sec
> Start 3: plasma-packagestructuretest
> 3/10 Test #3: plasma-packagestructuretest ........***Failed 0.19 sec
> Start 4: plasma-packageurlinterceptortest
> 4/10 Test #4: plasma-packageurlinterceptortest ... Passed 0.12 sec
> Start 5: plasma-pluginloadertest
> 5/10 Test #5: plasma-pluginloadertest ............ Passed 1.44 sec
> Start 6: plasma-framesvgtest
> 6/10 Test #6: plasma-framesvgtest ................ Passed 0.64 sec
> Start 7: coronatest
> 7/10 Test #7: coronatest .........................***Failed 0.16 sec
> Start 8: plasma-storagetest
> 8/10 Test #8: plasma-storagetest .................***Failed 0.12 sec
> Start 9: plasma-sortfiltermodeltest
> 9/10 Test #9: plasma-sortfiltermodeltest ......... Passed 0.14 sec
> Start 10: i18ndcheck
> Could not find executable SH-NOTFOUND
> Looked in the following places:
> SH-NOTFOUND
> SH-NOTFOUND.exe
> Release/SH-NOTFOUND
> Release/SH-NOTFOUND.exe
> Debug/SH-NOTFOUND
> Debug/SH-NOTFOUND.exe
> MinSizeRel/SH-NOTFOUND
> MinSizeRel/SH-NOTFOUND.exe
> RelWithDebInfo/SH-NOTFOUND
> RelWithDebInfo/SH-NOTFOUND.exe
> Deployment/SH-NOTFOUND
> Deployment/SH-NOTFOUND.exe
> Development/SH-NOTFOUND
> Development/SH-NOTFOUND.exe
> Unable to find executable: SH-NOTFOUND
> 10/10 Test #10: i18ndcheck .........................***Not Run 0.00 sec
>
> 50% tests passed, 5 tests failed out of 10
>
>
> Thanks,
>
> Andrius da Costa Ribas
>
>
--===============6694764946154471683==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120877/">https://git.reviewboard.kde.org/r/120877/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No \
opinion on the patch but please check your coding style.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120877/diff/1/?file=322758#file322758line57" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/plasma/private/framesvg_helpers.h</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">namespace FrameSvgHelpers</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">57</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">38</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="p">}</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">39</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">else</span> <span class="k">if</span> <span class="p">(</span><span \
class="n">borders</span> <span class="o">==</span> <span \
class="n">FrameSvg</span><span class="o">::</span><span \
class="n">TopBorder</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Always put the brace on the same line as the else if</p></pre> </div>
</div>
<br />
<p>- Kai Uwe Broulik</p>
<br />
<p>On Oktober 29th, 2014, 2:09 vorm. UTC, Andrius da Costa Ribas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdewin and Plasma.</div>
<div>By Andrius da Costa Ribas.</div>
<p style="color: grey;"><i>Updated Okt. 29, 2014, 2:09 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">MSVC is unable to recognise e.g. FrameSvg::TopBorder | \
FrameSvg::LeftBorder as a compile-time const expression (error C2051: case expression \
not constant)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds with MSVC 2013 64bit.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">framesvg related tests pass, other unrelated tests still fail.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Test project V:/build/frameworks/plasma/work/msvc2013-RelWithDebInfo-master \
Start 1: plasma-dialogqmltest 1/10 Test #1: plasma-dialogqmltest \
...............<strong style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;"><em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Failed 1.15 sec \
Start 2: plasma-fallbackpackagetest 2/10 Test #2: plasma-fallbackpackagetest \
......... Passed 0.16 sec Start 3: plasma-packagestructuretest
3/10 Test #3: plasma-packagestructuretest ........</em></strong>Failed 0.19 sec
Start 4: plasma-packageurlinterceptortest
4/10 Test #4: plasma-packageurlinterceptortest ... Passed 0.12 sec
Start 5: plasma-pluginloadertest
5/10 Test #5: plasma-pluginloadertest ............ Passed 1.44 sec
Start 6: plasma-framesvgtest
6/10 Test #6: plasma-framesvgtest ................ Passed 0.64 sec
Start 7: coronatest
7/10 Test #7: coronatest .........................<strong style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"><em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Failed 0.16 sec Start 8: plasma-storagetest
8/10 Test #8: plasma-storagetest .................</em></strong>Failed 0.12 sec
Start 9: plasma-sortfiltermodeltest
9/10 Test #9: plasma-sortfiltermodeltest ......... Passed 0.14 sec
Start 10: i18ndcheck
Could not find executable SH-NOTFOUND
Looked in the following places:
SH-NOTFOUND
SH-NOTFOUND.exe
Release/SH-NOTFOUND
Release/SH-NOTFOUND.exe
Debug/SH-NOTFOUND
Debug/SH-NOTFOUND.exe
MinSizeRel/SH-NOTFOUND
MinSizeRel/SH-NOTFOUND.exe
RelWithDebInfo/SH-NOTFOUND
RelWithDebInfo/SH-NOTFOUND.exe
Deployment/SH-NOTFOUND
Deployment/SH-NOTFOUND.exe
Development/SH-NOTFOUND
Development/SH-NOTFOUND.exe
Unable to find executable: SH-NOTFOUND
10/10 Test #10: i18ndcheck .........................***Not Run 0.00 sec</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">50% tests passed, 5 tests failed out of 10</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/private/framesvg_helpers.h <span style="color: \
grey">(5b96cd5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120877/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6694764946154471683==--
_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic