[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-windows
Subject: Re: Review Request 120096: replace static arrays with dynamic size with QVector
From: "Milian Wolff" <mail () milianw ! de>
Date: 2014-09-08 11:24:32
Message-ID: 20140908112432.8756.50083 () probe ! kde ! org
[Download RAW message or body]
--===============7348393935000847328==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120096/#review66046
-----------------------------------------------------------
src/k7zip.cpp
<https://git.reviewboard.kde.org/r/120096/#comment46117>
This must be resize, otherwise your codecID will be "empty". The `codecID[i]` \
below probably will assert in debug mode as well now.
src/k7zip.cpp
<https://git.reviewboard.kde.org/r/120096/#comment46118>
this could be a QByteArray directly, and again resize it, not reserve.
src/k7zip.cpp
<https://git.reviewboard.kde.org/r/120096/#comment46119>
this would be obsoleted if you use a QByteArray above directly
- Milian Wolff
On Sept. 7, 2014, 3:20 p.m., Patrick Spendrin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120096/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2014, 3:20 p.m.)
>
>
> Review request for KDE Frameworks and kdewin.
>
>
> Repository: karchive
>
>
> Description
> -------
>
> on windows static arrays can only be initialized with a const
>
>
> Diffs
> -----
>
> src/k7zip.cpp 2db043520ebff6bf7661e8ac993d107f4bd6a5e7
>
> Diff: https://git.reviewboard.kde.org/r/120096/diff/
>
>
> Testing
> -------
>
> windows
>
>
> Thanks,
>
> Patrick Spendrin
>
>
--===============7348393935000847328==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120096/">https://git.reviewboard.kde.org/r/120096/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120096/diff/1/?file=310286#file310286line728" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/k7zip.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Folder \
*K7Zip::K7ZipPrivate::folderItem()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">728</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="n">codecID</span><span class="p">.</span><span \
class="n">reserve</span><span class="p">(</span><span \
class="n">codecIdSize</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
must be resize, otherwise your codecID will be "empty". The <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">codecID[i]</code> below probably will assert in debug mode \
as well now.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120096/diff/1/?file=310286#file310286line1509" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/k7zip.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QByteArray K7Zip::K7ZipPrivate::readAndDecodePackedStreams(bool \
readMainStreamInfo)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1508</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">char</span> <span class="n">encodedBuffer</span><span class="p"><span \
class="hl">[</span></span><span class="n"><span class="hl">size</span></span><span \
class="p"><span class="hl">]</span>;</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1509</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n"><span class="hl">QVector</span></span><span class="o"><span \
class="hl"><</span></span><span class="kt">char</span><span class="o"><span \
class="hl">></span></span> <span class="n">encodedBuffer</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this \
could be a QByteArray directly, and again resize it, not reserve.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120096/diff/1/?file=310286#file310286line1518" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/k7zip.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QByteArray K7Zip::K7ZipPrivate::readAndDecodePackedStreams(bool \
readMainStreamInfo)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1516</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QByteArray</span> <span class="n">deflatedData</span><span \
class="p">(</span><span class="n">encodedBuffer</span><span class="p">,</span> <span \
class="n">size</span><span class="p">);</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1518</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QByteArray</span> <span class="n">deflatedData</span><span \
class="p">(</span><span class="n">encodedBuffer</span><span class="p"><span \
class="hl">.</span></span><span class="n"><span \
class="hl">constData</span></span><span class="p"><span class="hl">()</span>,</span> \
<span class="n">size</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this \
would be obsoleted if you use a QByteArray above directly</p></pre> </div>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On September 7th, 2014, 3:20 p.m. UTC, Patrick Spendrin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and kdewin.</div>
<div>By Patrick Spendrin.</div>
<p style="color: grey;"><i>Updated Sept. 7, 2014, 3:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
karchive
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">on windows static arrays can only be initialized with \
a const</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">windows</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/k7zip.cpp <span style="color: \
grey">(2db043520ebff6bf7661e8ac993d107f4bd6a5e7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120096/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7348393935000847328==--
_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic