'Re: Review Request 117828: prevent ex/import in exported classes used in tests'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-windows
Subject:    Re: Review Request 117828: prevent ex/import in exported classes used in tests
From:       "Vishesh Handa" <me () vhanda ! in>
Date:       2014-04-28 12:43:55
Message-ID: 20140428124355.12926.71580 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117828/#review56739
-----------------------------------------------------------

Ship it!

I don't get why MSVC doesn't just ignore it, but sure.

- Vishesh Handa

On April 28, 2014, 9:50 a.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117828/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 9:50 a.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> If using class definitions of exported classes in tests, the export/import \
> mechanism isn't needed. To prevent linker errors, set the EXPORT macro to empty. 
> 
> Diffs
> -----
> 
> src/file/autotest/CMakeLists.txt a54736e 
> src/file/autotest/fileindexingjob/CMakeLists.txt 811ed30 
> src/file/lib/autotests/CMakeLists.txt 95a0916 
> src/file/search/autotest/CMakeLists.txt eb058d2 
> src/file/tests/CMakeLists.txt 102c981 
> 
> Diff: https://git.reviewboard.kde.org/r/117828/diff/
> 
> 
> Testing
> -------
> 
> windows msvc 2010
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117828/">https://git.reviewboard.kde.org/r/117828/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don&#39;t get why MSVC \
doesn&#39;t just ignore it, but sure.</pre>  <br />

<p>- Vishesh Handa</p>

<br />
<p>On April 28th, 2014, 9:50 a.m. UTC, Patrick Spendrin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Baloo and kdewin.</div>
<div>By Patrick Spendrin.</div>

<p style="color: grey;"><i>Updated April 28, 2014, 9:50 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If using class definitions of exported classes in tests, the \
export/import mechanism isn&#39;t needed. To prevent linker errors, set the EXPORT \
macro to empty.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">windows msvc 2010</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/file/autotest/CMakeLists.txt <span style="color: grey">(a54736e)</span></li>

 <li>src/file/autotest/fileindexingjob/CMakeLists.txt <span style="color: \
grey">(811ed30)</span></li>

 <li>src/file/lib/autotests/CMakeLists.txt <span style="color: \
grey">(95a0916)</span></li>

 <li>src/file/search/autotest/CMakeLists.txt <span style="color: \
grey">(eb058d2)</span></li>

 <li>src/file/tests/CMakeLists.txt <span style="color: grey">(102c981)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117828/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

[prev in list] [next in list] [prev in thread] [next in thread] 