[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-windows
Subject: Re: Review Request 114964: Fix duplicated typedef for ssize_t on MSVC for python backend
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2014-01-11 16:11:22
Message-ID: 20140111161122.7621.95902 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 11, 2014, 2:52 p.m., Albert Astals Cid wrote:
> > src/backends/python2/CMakeLists.txt, line 15
> > <https://git.reviewboard.kde.org/r/114964/diff/1/?file=233720#file233720line15>
> >
> > Shouldn't this go into the kdewin include files then?
>
> Andrius da Costa Ribas wrote:
> kdewin does this
> http://quickgit.kde.org/?p=kdewin.git&a=blob&h=056cd64165e3e5c76d7878c13806551dca7c3182&hb=ae1c0ac291cc97d432b73091bb17b32120038b6c&f=include%2Fmsvc%2Fsys%2Ftypes.h
>
> #ifndef _SSIZE_T_DEFINED
> #define _SSIZE_T_DEFINED
> typedef SSIZE_T ssize_t;
> #endif
>
> the problem is that the python one doesn't.
>
Ah, i see what you mean. Quick question, how does kdewin headers end up in cantor?
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114964/#review47190
-----------------------------------------------------------
On Jan. 11, 2014, 2:37 p.m., Andrius da Costa Ribas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114964/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2014, 2:37 p.m.)
>
>
> Review request for KDE Edu, kdewin, Alexander Rieder, and Filipe Saraiva.
>
>
> Repository: cantor
>
>
> Description
> -------
>
> This typedef is in both kdewin's sys/types (msvc/include) and python config \
> headers. By adding this definition the typedef present in kdewin is skipped.
>
> Diffs
> -----
>
> src/backends/python2/CMakeLists.txt d27d88f
>
> Diff: https://git.reviewboard.kde.org/r/114964/diff/
>
>
> Testing
> -------
>
> Python backend builds and run fine from a clean MSVC build.
> MinGW build was already okay, as per \
> http://winkde.org/pub/kde/ports/win32/repository-4.12/logs/log-mingw-w32-kde_cantor.txt
>
>
> Thanks,
>
> Andrius da Costa Ribas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114964/">https://git.reviewboard.kde.org/r/114964/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 11th, 2014, 2:52 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114964/diff/1/?file=233720#file233720line15" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/backends/python2/CMakeLists.txt</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">15</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">add_definitions</span><span class="p">(</span><span \
class="s">-D_SSIZE_T_DEFINED</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shouldn't this go \
into the kdewin include files then?</pre> </blockquote>
<p>On January 11th, 2014, 3:58 p.m. UTC, <b>Andrius da Costa Ribas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kdewin does this \
http://quickgit.kde.org/?p=kdewin.git&a=blob&h=056cd64165e3e5c76d7878c13806551 \
dca7c3182&hb=ae1c0ac291cc97d432b73091bb17b32120038b6c&f=include%2Fmsvc%2Fsys%2Ftypes.h
#ifndef _SSIZE_T_DEFINED
#define _SSIZE_T_DEFINED
typedef SSIZE_T ssize_t;
#endif
the problem is that the python one doesn't.
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah, i see \
what you mean. Quick question, how does kdewin headers end up in cantor?</pre> <br />
<p>- Albert</p>
<br />
<p>On January 11th, 2014, 2:37 p.m. UTC, Andrius da Costa Ribas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu, kdewin, Alexander Rieder, and Filipe Saraiva.</div>
<div>By Andrius da Costa Ribas.</div>
<p style="color: grey;"><i>Updated Jan. 11, 2014, 2:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This typedef is in both kdewin's sys/types (msvc/include) and python \
config headers. By adding this definition the typedef present in kdewin is \
skipped.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Python backend builds and run fine from a clean MSVC build. MinGW build \
was already okay, as per \
http://winkde.org/pub/kde/ports/win32/repository-4.12/logs/log-mingw-w32-kde_cantor.txt</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/backends/python2/CMakeLists.txt <span style="color: \
grey">(d27d88f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114964/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic