[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-windows
Subject:    Fwd: Re: Review Request 109246: Make KUrl::relativePath and KUrl::relativeUrl work correctly on Wind
From:       "Thomas Friedrichsmeier" <thomas.friedrichsmeier () ruhr-uni-bochum ! de>
Date:       2013-05-23 8:44:49
Message-ID: 2198141.gvNS2jG4px () late
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hi!

I'm under the impression, not too many KDE-Windows folks are following kde-
core-devel (I'm doing so rather cursorily and sporadically, myself). So, just 
in case, I'll forward the review request, below.

Looks good to me on first glance, but I'm really not an expert on the many 
pitfalls of KUrl.

Regards
Thomas

----------  Forwarded Message  ----------

Subject: Re: Review Request 109246: Make KUrl::relativePath and 
KUrl::relativeUrl work correctly on Windows
Date: Saturday 18 May 2013, 14:36:35
From: Allen Winter <winter@kde.org>
To: Michel Ludwig <michel.ludwig@gmail.com>, Allen Winter <winter@kde.org>, 
kdelibs <kde-core-devel@kde.org>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109246/#review32742
-----------------------------------------------------------


any KDE Windows folks feel like taking a look at this one?


- Allen Winter


On March 2, 2013, 4:54 p.m., Michel Ludwig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109246/
> -----------------------------------------------------------
> 
> (Updated March 2, 2013, 4:54 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Absolute paths can, for example, have the form 
"E:/MyDocuments/test/test.tex" on Windows. Currently, KUrl::_relativePath 
assumes that 
> "E:/MyDocuments/test/test.tex" is a relative path and
> 
>   KUrl::relativePath("E:/MyDocuments/", "E:/MyDocuments/test/test.tex") 
> 
> will therefore return "E:/MyDocuments/test/test.tex" instead of 
"test/test.tex". The attached patch fixes this issue.
> 
> 
> Diffs
> -----
> 
>   kdecore/io/kurl.cpp ef2ba12 
> 
> Diff: http://git.reviewboard.kde.org/r/109246/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michel Ludwig
> 
>

-----------------------------------------
["signature.asc" (application/pgp-signature)]

_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows


[prev in list] [next in list] [prev in thread] [next in thread]