'Re: Review Request: cannot compile qt if kderoot path is too long'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-windows
Subject:    Re: Review Request: cannot compile qt if kderoot path is too long
From:       "Wolfgang Rohdewald" <wolfgang () rohdewald ! de>
Date:       2011-02-15 13:31:35
Message-ID: 20110215133135.1229.34150 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6483/
-----------------------------------------------------------

(Updated Feb. 15, 2011, 1:31 p.m.)

Review request for kde-windows.

Changes
-------

New patch: Only change qt compilation. If kderoot is long and the useShortP=
athes is not yet set, set it and log a warning about it.

Summary (updated)
-------

On windows, gcc/g++ only take a maximum of 8192 chars for command line argu=
ments. If they get more they will not complain but strange things will happ=
en like compiler segfaulting or gcc misinterpreting the arguments at around=
 position 8192. I did not report this as a gcc bug, maybe somebody else alr=
eady is registered wherever that can be done. I was using mingw4.

So emerge.py now first checks - it allows a maximum of 10 chars like in c:\=
kderoot. This results in command line lengths up to around 7700 (maybe more=
, this is what I saw).

I was using kderootsvn which makes gcc die when compiling c:\kderootsvn\dow=
nload\svn-src\qt\src\3rdparty\sqlite\sqlite3.c, the command line having a l=
ength of 8214

Diffs (updated)
-----

  /trunk/kdesupport/emerge/portage/libs/qt/qt-4.7.1.20101224.py 1220833 =

Diff: http://svn.reviewboard.kde.org/r/6483/diff

Testing (updated)
-------

qt compiles with useShortPathes and a long kderoot

Thanks,

Wolfgang

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6483/">http://svn.reviewboard.kde.org/r/6483/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kde-windows.</div>
<div>By Wolfgang Rohdewald.</div>

<p style="color: grey;"><i>Updated Feb. 15, 2011, 1:31 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">New patch: Only change qt compilation. If kderoot is long and the \
useShortPathes is not yet set, set it and log a warning about it.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">On windows, gcc/g++ only take a maximum of 8192 chars for command line \
arguments. If they get more they will not complain but strange things will happen \
like compiler segfaulting or gcc misinterpreting the arguments at around position \
8192. I did not report this as a gcc bug, maybe somebody else already is registered \
wherever that can be done. I was using mingw4.

So emerge.py now first checks - it allows a maximum of 10 chars like in c:\kderoot. \
This results in command line lengths up to around 7700 (maybe more, this is what I \
saw).

I was using kderootsvn which makes gcc die when compiling \
c:\kderootsvn\download\svn-src\qt\src\3rdparty\sqlite\sqlite3.c, the command line \
having a length of 8214</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">qt compiles with useShortPathes and a long kderoot</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/kdesupport/emerge/portage/libs/qt/qt-4.7.1.20101224.py <span \
style="color: grey">(1220833)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6483/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

[prev in list] [next in list] [prev in thread] [next in thread] 