From kde-windows Tue Jan 18 20:41:28 2011 From: "Ralf Habacker" Date: Tue, 18 Jan 2011 20:41:28 +0000 To: kde-windows Subject: Re: Review Request: remove unneeded attributes from Message-Id: <20110118204128.7877.82057 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-windows&m=129538335027874 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1052395543==" --===============1052395543== Content-Type: multipart/alternative; boundary="===============0044413716039043496==" --===============0044413716039043496== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6344/#review9651 ----------------------------------------------------------- Ship it! looks good to me - Ralf On Jan. 16, 2011, 11:23 p.m., Wolfgang Rohdewald wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6344/ > ----------------------------------------------------------- > = > (Updated Jan. 16, 2011, 11:23 p.m.) > = > = > Review request for kde-windows. > = > = > Summary > ------- > = > NullsoftInstallerPackager: eliminate attributes whitelists and blackl= ists > they are not used anywhere outside of __init__ > = > = > Diffs > ----- > = > /trunk/kdesupport/emerge/bin/Packager/NullsoftInstallerPackager.py 1214= 807 = > = > Diff: http://svn.reviewboard.kde.org/r/6344/diff > = > = > Testing > ------- > = > = > Thanks, > = > Wolfgang > = > --===============0044413716039043496== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6344/

Ship it!

looks good=
 to me

- Ralf

On January 16th, 2011, 11:23 p.m., Wolfgang Rohdewald wrote:

Review request for kde-windows.

By Wolfgang Rohdewald.

Updated Jan. 16, 2011, 11:23 p.m.

Descripti= on

    NullsoftInstallerPackager: eliminate attributes whitelis=
ts and blacklists
    they are not used anywhere outside of __init__

Diffs=

/trunk/kdesupport/emerge/bin/Packager/NullsoftInstallerPackager.py (1214807)

View Diff

--===============0044413716039043496==-- --===============1052395543== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows --===============1052395543==--