This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6340/

Ship it!

looks good to me. 

- Ralf


On January 16th, 2011, 1:10 p.m., Wolfgang Rohdewald wrote:

Review request for kde-windows.
By Wolfgang Rohdewald.

Updated Jan. 16, 2011, 1:10 p.m.

Description

    Simplify verbosity handling code:
    - do not use global variables anymore (pylint)
    - introduce a class Verbosity instead
    - alyways keep shell variable EMERGE_VERBOSE in sync
    - new context class TemporaryVerbosity. Use it in dumpDependencies

Diffs

  • /trunk/kdesupport/emerge/bin/dependencies.py (1214807)
  • /trunk/kdesupport/emerge/bin/emerge.py (1214807)
  • /trunk/kdesupport/emerge/bin/tools.py (1214807)
  • /trunk/kdesupport/emerge/bin/utils.py (1214807)

View Diff