From kde-windows Wed Aug 04 12:06:33 2010 From: "Ralf Habacker" Date: Wed, 04 Aug 2010 12:06:33 +0000 To: kde-windows Subject: Re: Review Request: Debug packages support in kdewin-installer Message-Id: <20100804120633.25663.25181 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-windows&m=128092364721099 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0821844331==" --===============0821844331== Content-Type: multipart/alternative; boundary="===============8287748839081847222==" --===============8287748839081847222== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4899/#review6791 ----------------------------------------------------------- Looks good so far. I committed it with a spelling fix = + if ( installedPackage->isInstalled ( Package::DBG ) ) + list +=3D tr ( "---- SRC package ----" ) + "\n" + engine->data= base()->getPackageFiles ( installedPackage->name(),Package::DBG ).join ( "\= n" ) + "\n"; if ( list.isEmpty() ) should be = + if ( installedPackage->isInstalled ( Package::DBG ) ) + list +=3D tr ( "---- DBG package ----" ) + "\n" + engine->data= base()->getPackageFiles ( installedPackage->name(),Package::DBG ).join ( "\= n" ) + "\n"; if ( list.isEmpty() ) - Ralf On 2010-08-04 10:01:33, Ilie Halip wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4899/ > ----------------------------------------------------------- > = > (Updated 2010-08-04 10:01:33) > = > = > Review request for kde-windows. > = > = > Summary > ------- > = > This patch adds a new package type: DBG, and a new column in the packages= list view, making it possible to install debug packages on Windows. This d= oes not address the server-side build scripts. > = > = > Diffs > ----- > = > /trunk/kdesupport/kdewin-installer/console/installerengineconsole.cpp 1= 159076 = > /trunk/kdesupport/kdewin-installer/gui/installerenginegui.cpp 1159076 = > /trunk/kdesupport/kdewin-installer/gui/packageselectorpage.cpp 1159076 = > /trunk/kdesupport/kdewin-installer/shared/globalconfig.cpp 1159076 = > /trunk/kdesupport/kdewin-installer/shared/package.h 1159076 = > /trunk/kdesupport/kdewin-installer/shared/package.cpp 1159076 = > /trunk/kdesupport/kdewin-installer/shared/packagelist.cpp 1159076 = > /trunk/kdesupport/kdewin-installer/shared/packagestates.h 1159076 = > /trunk/kdesupport/kdewin-installer/shared/packagestates.cpp 1159076 = > = > Diff: http://reviewboard.kde.org/r/4899/diff > = > = > Testing > ------- > = > - locally tested kdewin-installer > - made sure it works with the current mirrors > = > = > Thanks, > = > Ilie > = > --===============8287748839081847222== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/4899/ 

Looks good=
 so far. I committed it with a spelling fix =


+        if ( installedPackage->isInstalled ( Package::DBG ) )
+            list +=3D tr ( "---- SRC package ----" ) + "\n&=
quot; + engine->database()->getPackageFiles ( installedPackage->na=
me(),Package::DBG ).join ( "\n" ) + "\n";
         if ( list.isEmpty() )

should be =


+        if ( installedPackage->isInstalled ( Package::DBG ) )
+            list +=3D tr ( "---- DBG package ----" ) + "\n&=
quot; + engine->database()->getPackageFiles ( installedPackage->na=
me(),Package::DBG ).join ( "\n" ) + "\n";
         if ( list.isEmpty() )

- Ralf


On August 4th, 2010, 10:01 a.m., Ilie Halip wrote:

Review request for kde-windows.
By Ilie Halip.

Updated 2010-08-04 10:01:33

Descripti= on 

This patch adds a new package type: DBG, and a new column in=
 the packages list view, making it possible to install debug packages on Wi=
ndows. This does not address the server-side build scripts.

Testing <= /h1> 
- locally tested kdewin-installer
- made sure it works with the current mirrors

Diffs=

  • /trunk/kdesupport/kdewin-installer/console/installerengineconsole.cpp = (1159076)
  • /trunk/kdesupport/kdewin-installer/gui/installerenginegui.cpp (1159076)
  • /trunk/kdesupport/kdewin-installer/gui/packageselectorpage.cpp (1159076)
  • /trunk/kdesupport/kdewin-installer/shared/globalconfig.cpp (1159076)
  • /trunk/kdesupport/kdewin-installer/shared/package.h (1159076)
  • /trunk/kdesupport/kdewin-installer/shared/package.cpp (1159076)
  • /trunk/kdesupport/kdewin-installer/shared/packagelist.cpp (1159076)
  • /trunk/kdesupport/kdewin-installer/shared/packagestates.h (1159076)
  • /trunk/kdesupport/kdewin-installer/shared/packagestates.cpp (1159076)

View Diff
--===============8287748839081847222==-- --===============0821844331== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows --===============0821844331==--