[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-windows
Subject:    Re: KDE/kdelibs/kfile
From:       Andreas Pakulat <apaku () gmx ! de>
Date:       2009-08-24 8:30:22
Message-ID: 20090824083022.GA20022 () neo ! apaku ! dnsalias ! org
[Download RAW message or body]

On 24.08.09 08:08:30, Christian Ehrlicher wrote:
> -------- Original-Nachricht --------
> > Datum: Mon, 24 Aug 2009 05:32:09 +0000
> > Von: Casper van Donderen
> > An: kde-commits@kde.org
> > Betreff: KDE/kdelibs/kfile
> 
> > SVN commit 1014877 by cvandonderen:
> > 
> > Fix crash in Winodws where the kfilemodule was not found because it was
> > called libkfilemodule.
> > 
> > 
> >  M  +1 -1      CMakeLists.txt  
> > 
> > 
> > --- trunk/KDE/kdelibs/kfile/CMakeLists.txt #1014876:1014877
> > @@ -73,6 +73,6 @@
> >  set(kfilemodule_SRCS
> >    kfilemodule.cpp
> >  )
> > -kde4_add_plugin(kfilemodule WITH_PREFIX ${kfilemodule_SRCS})
> > +kde4_add_plugin(kfilemodule ${kfilemodule_SRCS})
> >  target_link_libraries(kfilemodule ${KDE4_KFILE_LIBS})
> >  install(TARGETS kfilemodule DESTINATION ${PLUGIN_INSTALL_DIR})
> 
> Do you know that WITH_PREFIX wasn't added because someone needed it?

A quick svn blame indicates that this is how dfaure initially created it
back in 2007. IIRC at that point there was no warning yet about plugins
using lib-prefix, so I doubt there is any reason for the WITH_PREFIX.

Andreas

-- 
You are going to have a new love affair.
_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows
[prev in list] [next in list] [prev in thread] [next in thread]