This is a multi-part message in MIME format. --------------080707020005010606040507 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Alexander Neundorf said the following, On 2007-11-08 21:51: > On Thursday 08 November 2007, Allen Winter wrote: >> On Wednesday 07 November 2007 15:42:28 Alexander Neundorf wrote: >>> On Monday 05 November 2007, Alexander Neundorf wrote: >>>> On Monday 05 November 2007, you wrote: >>> ... >>> >>>>> And I agree. We shouldn't be linking to plugins. >>>> So, does anybody else still have objections against removing >>>> "WITH_PREFIX" ? >>> So, conclusion: I'll remove the "WITH_PREFIX" option and no plugins will >>> have the "lib" prefix anymore, I'll commit next monday. >> This coming Monday is a bad time. We are trying to tag a Development >> Platform. I think this will cause a lot of breakage in the apps, which will >> cause extra frustration and delays we don't need at this time. > > So how about the monday after that ? > It only changes the name of the created plugin, and if I understood correctly > they are searched in both versions currently, so why do you think it could > cause a lot of breakage ? > > Jaroslow, what do you think ? I'll try to present as simple solution as possible from my POV. Surprisingly, I'd go with "1) leave it as it is and keep the "WITH_PREFIX" option, so some plugins have the "lib" prefix and others don't" (for now) why? 1. it's a tagging time 2. I've already cooked a code (the patch is attached; please review) that: (a) adds a "lib" prefix for an init_ symbol name in case when a symbol without the "lib" prefix is not found ; see part of the patch related to klibrary.cpp (b) by the way it simplifies some redundant windows lib/plugin loading code from kdecore/util/ - - re linking to modules: I am unsure whether allowing linking to modules is a big win, when the price paid is a bit more obfuscated design for kde dev platform's runtime. But note, to use symbols from a module that is also used as a lib, we need to export symbols. So we should not forget that app_export.h export files have to contain another FOOMODULE_EXPORT macro as well. We need to somehow force cmake to define a kind of MAKE_***_LIB macro for us while compiling such special modules to export expected symbols other than its entry point. Does it work already? E.g. note that on windows library binaries go to bin/ (${LIB_INSTALL_DIR} == bin) so binaries of the special modules would go there as well, something not very appealing (we want to avoid a need for multiple locations for binaries what would force us to modify the $PATH so we install .exe's and .dll's in the same place). The next step would be to use lib prefix _only_ when module is also used as a lib. -- regards / pozdrawiam, Jaroslaw Staniek Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on Kexi & KOffice: http://www.kexi.pl/en, http://www.koffice.org KDE3 & KDE4 Libraries for MS Windows: http://kdelibs.com, http://www.kde.org --------------080707020005010606040507 Content-Type: text/plain; name="util.patch" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="util.patch" SW5kZXg6IGtsaWJsb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGtsaWJsb2FkZXIuY3Bw CSh3ZXJzamEgNzMxNTQyKQorKysga2xpYmxvYWRlci5jcHAJKGtvcGlhIHJvYm9jemEpCkBA IC01OSw0MSArNTksMzMgQEAKIAogZXh0ZXJuIFFTdHJpbmcgbWFrZUxpYk5hbWUoIGNvbnN0 IFFTdHJpbmcgJmxpYm5hbWUgKTsKIAotZXh0ZXJuIFFTdHJpbmcgZmluZExpYnJhcnlJbnRl cm5hbChjb25zdCBRU3RyaW5nICZuYW1lLCBjb25zdCBLQ29tcG9uZW50RGF0YSAmY0RhdGEp OworZXh0ZXJuIFFTdHJpbmcgZmluZExpYnJhcnkoY29uc3QgUVN0cmluZyAmbmFtZSwgY29u c3QgS0NvbXBvbmVudERhdGEgJmNEYXRhKTsKIAotLy9zdGF0aWMKLVFTdHJpbmcgS0xpYkxv YWRlcjo6ZmluZExpYnJhcnkoY29uc3QgUVN0cmluZyAmX25hbWUsIGNvbnN0IEtDb21wb25l bnREYXRhICZjRGF0YSkKLXsKLSAgICBRU3RyaW5nIGxpYm5hbWUgPSBmaW5kTGlicmFyeUlu dGVybmFsKFFEaXI6OmZyb21OYXRpdmVTZXBhcmF0b3JzKF9uYW1lKSwgY0RhdGEpOwogI2lm ZGVmIFFfT1NfV0lOCi0gICAgLy8gd2UgZG9uJ3QgaGF2ZSAnbGliJyBwcmVmaXggb24gd2lu ZG93cyAtPiByZW1vdmUgaXQgYW5kIHRyeSBhZ2FpbgotICAgIGlmKCBsaWJuYW1lLmlzRW1w dHkoKSApCisvLyByZW1vdmVzICJsaWIiIHByZWZpeCwgaWYgcHJlc2VudAorUVN0cmluZyBm aXhMaWJQcmVmaXgoY29uc3QgUVN0cmluZyYgbGlibmFtZSkKK3sKKyAgICBpbnQgcG9zID0g bGlibmFtZS5sYXN0SW5kZXhPZiggJy8nICk7CisgICAgaWYgKCBwb3MgPj0gMCApCiAgICAg ewotICAgICAgbGlibmFtZSA9IF9uYW1lOwotICAgICAgUVN0cmluZyBmaWxlLCBwYXRoOwot Ci0gICAgICBpbnQgcG9zID0gbGlibmFtZS5sYXN0SW5kZXhPZiggJy8nICk7Ci0gICAgICBp ZiAoIHBvcyA+PSAwICkKLSAgICAgIHsKLSAgICAgICAgZmlsZSA9IGxpYm5hbWUubWlkKCBw b3MgKyAxICk7Ci0gICAgICAgIHBhdGggPSBsaWJuYW1lLmxlZnQoIHBvcyApOwotICAgICAg ICBsaWJuYW1lID0gcGF0aCArICcvJyArIGZpbGUubWlkKCAzICk7Ci0gICAgICB9Ci0gICAg ICBlbHNlCi0gICAgICB7Ci0gICAgICAgIGZpbGUgPSBsaWJuYW1lOwotICAgICAgICBsaWJu YW1lID0gZmlsZS5taWQoIDMgKTsKLSAgICAgIH0KLSAgICAgIGlmKCAhZmlsZS5zdGFydHNX aXRoKCAibGliIiApICkKLSAgICAgICAgICByZXR1cm4gbGlibmFtZTsKLQotICAgICAgbGli bmFtZSA9IGZpbmRMaWJyYXJ5SW50ZXJuYWwobGlibmFtZSwgY0RhdGEpOworICAgICAgICBR U3RyaW5nIGZpbGUgPSBsaWJuYW1lLm1pZCggcG9zICsgMSApOworICAgICAgICBRU3RyaW5n IHBhdGggPSBsaWJuYW1lLmxlZnQoIHBvcyApOworICAgICAgICBpZiggIWZpbGUuc3RhcnRz V2l0aCggImxpYiIgKSApCisgICAgICAgICAgICByZXR1cm4gbGlibmFtZTsKKyAgICAgICAg cmV0dXJuIHBhdGggKyAnLycgKyBmaWxlLm1pZCggMyApOwogICAgIH0KKyAgICBpZiggIWxp Ym5hbWUuc3RhcnRzV2l0aCggImxpYiIgKSApCisgICAgICAgIHJldHVybiBsaWJuYW1lOwor ICAgIHJldHVybiBsaWJuYW1lLm1pZCggMyApOworfQogI2VuZGlmCi0gICAgcmV0dXJuIGxp Ym5hbWU7CisKKy8vc3RhdGljCitRU3RyaW5nIEtMaWJMb2FkZXI6OmZpbmRMaWJyYXJ5KGNv bnN0IFFTdHJpbmcgJl9uYW1lLCBjb25zdCBLQ29tcG9uZW50RGF0YSAmY0RhdGEpCit7Cisg ICAgcmV0dXJuIDo6ZmluZExpYnJhcnkoX25hbWUsIGNEYXRhKTsKIH0KIAotCiBLTGlicmFy eSogS0xpYkxvYWRlcjo6bGlicmFyeSggY29uc3QgUVN0cmluZyAmX25hbWUsIFFMaWJyYXJ5 OjpMb2FkSGludHMgaGludCApCiB7CiAgICAgaWYgKF9uYW1lLmlzRW1wdHkoKSkKSW5kZXg6 IGtsaWJyYXJ5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBrbGlicmFyeS5jcHAJKHdlcnNqYSA3 MzQ0NzQpCisrKyBrbGlicmFyeS5jcHAJKGtvcGlhIHJvYm9jemEpCkBAIC0xMTMsNiArMTEz LDExIEBACiAgICAgdF9mdW5jIGZ1bmMgPSByZWludGVycHJldF9jYXN0PHRfZnVuYz4obGli LT5yZXNvbHZlRnVuY3Rpb24oIHN5bW5hbWUgKSk7CiAgICAgaWYgKCAhZnVuYyApCiAgICAg eworI2lmZGVmIFFfT1NfV0lOCisgICAgICAgIC8vIGEgYmFja3VwIGZvciBjYXNlcyB3aGVu IGRldmVsb3BlciBoYXMgc2V0IGxpYiBwcmVmaXggZm9yIGEgcGx1Z2luIG5hbWUgKHNoZSBz aG91bGQgbm90Li4uKQorICAgICAgICBpZiAoIWZhY3RvcnluYW1lLnN0YXJ0c1dpdGgoImxp YiIpKQorICAgICAgICAgICAgcmV0dXJuIGtkZTNGYWN0b3J5KGxpYiwgUUJ5dGVBcnJheSgi bGliIikrc3ltbmFtZS5taWQoNSAvKiJpbml0XyIqLykpOworI2VuZGlmCiAgICAgICAgIGtE ZWJ1ZygxNTApIDw8ICJUaGUgbGlicmFyeSIgPDwgbGliLT5maWxlTmFtZSgpIDw8ICJkb2Vz IG5vdCBvZmZlciBhbiIKICAgICAgICAgICAgICAgICAgICAgPDwgc3ltbmFtZSA8PCAiZnVu Y3Rpb24uIjsKICAgICAgICAgcmV0dXJuIDA7CkluZGV4OiBrcGx1Z2lubG9hZGVyLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBrcGx1Z2lubG9hZGVyLmNwcAkod2Vyc2phIDczMTU0MikKKysr IGtwbHVnaW5sb2FkZXIuY3BwCShrb3BpYSByb2JvY3phKQpAQCAtNzMsMjIgKzczLDI4IEBA CiAjZW5kaWYKIH0KIAorI2lmZGVmIFFfT1NfV0lOCitleHRlcm4gUVN0cmluZyBmaXhMaWJQ cmVmaXgoY29uc3QgUVN0cmluZyYgbGlibmFtZSk7CisjZW5kaWYKKwogaW5saW5lIFFTdHJp bmcgZmluZExpYnJhcnlJbnRlcm5hbChjb25zdCBRU3RyaW5nICZuYW1lLCBjb25zdCBLQ29t cG9uZW50RGF0YSAmY0RhdGEpCiB7CiAgICAgUVN0cmluZyBsaWJuYW1lID0gbWFrZUxpYk5h bWUobmFtZSk7CiAKICAgICBRRmlsZUluZm8gZmlsZWluZm8obmFtZSk7Ci0gICAgYm9vbCBo YXNQcmFlZml4ID0gZmlsZWluZm8uZmlsZU5hbWUoKS5zdGFydHNXaXRoKCJsaWIiKTsKKyAg ICBib29sIGhhc1ByZWZpeCA9IGZpbGVpbmZvLmZpbGVOYW1lKCkuc3RhcnRzV2l0aCgibGli Iik7CiAKLSAgICBpZiAoaGFzUHJhZWZpeCkKKyAgICBpZiAoaGFzUHJlZml4KQogICAgICAg ICBrRGVidWcoMTUwKSA8PCAicGx1Z2lucyBzaG91bGRuJ3QgaGF2ZSBhICdsaWInIHN1ZmZp eDoiIDw8IGxpYm5hbWU7CiAKICAgICBRU3RyaW5nIGxpYmZpbGU7CiAgICAgaWYgKFFEaXI6 OmlzUmVsYXRpdmVQYXRoKGxpYm5hbWUpKSB7CiAgICAgICAgIGxpYmZpbGUgPSBjRGF0YS5k aXJzKCktPmZpbmRSZXNvdXJjZSgibW9kdWxlIiwgbGlibmFtZSk7CiAgICAgICAgIGlmIChs aWJmaWxlLmlzRW1wdHkoKSkgewotI2lmbmRlZiBRX09TX1dJTgotICAgICAgICAgICAgaWYg KCFoYXNQcmFlZml4KQorI2lmZGVmIFFfT1NfV0lOCisgICAgICAgICAgICBsaWJuYW1lID0g Zml4TGliUHJlZml4KGxpYm5hbWUpOworI2Vsc2UKKyAgICAgICAgICAgIGlmICghaGFzUHJl Zml4KQogICAgICAgICAgICAgICAgIGxpYm5hbWUgPSBmaWxlaW5mby5wYXRoKCkgKyBRTGF0 aW4xU3RyaW5nKCIvbGliIikgKyBmaWxlaW5mby5maWxlTmFtZSgpOwogI2VuZGlmCiAgICAg ICAgICAgICBsaWJmaWxlID0gY0RhdGEuZGlycygpLT5maW5kUmVzb3VyY2UoImxpYiIsIGxp Ym5hbWUpOwo= --------------080707020005010606040507 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows --------------080707020005010606040507--