[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-windows
Subject:    Re: KUrl(QString) fix
From:       David Faure <faure () kde ! org>
Date:       2006-12-20 22:05:44
Message-ID: 200612202305.44782.faure () kde ! org
[Download RAW message or body]

On Wednesday 20 December 2006 18:52, Ralf Habacker wrote:
> David Faure schrieb:
> > On Wednesday 20 December 2006 18:30, Ralf Habacker wrote:
> >   
> >> As result it looks to me that in kde code toLocalFile() should be used 
> >> in every place where the local path of an url is used, not path()
> >>     
> >
> > Wow. That's a LOT of work...
> >
> >   
> May be a workaround on windows could be to call QUrl::toLocalFile() 
> instead of QUrl::path() in KUrl::path()

This might be a solution, as long as u.setPath(u.path()) still works, i.e. doesn't change u.

> Unfortunally KUrl::path() is an inline function. :-(

So? We haven't released kde-4.0 yet, it can be made non-inline any Monday.
It is inline right now only because of the overload that takes an argument, but the intent
wasn't that KUrl::path would work any differently from QUrl::path. But since we already
disagree with QUrl about a few things (like the use of toString), I'm not actually 
opposed to a solution where path() would work differently.

I can see how the path / toLocalFile separation makes sense now (on windows...),
but going ahead and changing all the kde code that uses urls sounds difficult.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows
[prev in list] [next in list] [prev in thread] [next in thread]