[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-utils-devel
Subject:    D9996: Initialize the translations of the ppd
From:       Luigi Toscano <noreply () phabricator ! kde ! org>
Date:       2018-01-20 19:33:02
Message-ID: 20180120193302.1.316049E382FAB9BF () phabricator ! kde ! org
[Download RAW message or body]

ltoscano created this revision.
ltoscano added a reviewer: dantti.
Restricted Application added a subscriber: kde-utils-devel.
ltoscano requested review of this revision.

REVISION SUMMARY
  The to ppdLocalize() make sure that the translated strings in the PPD for
  the current language are returned instead of the untranslated string.
  
  Unfortunately not all translations are returned, for example section
  titles are not translated (the translations are defined a bit differently
  in the PPD file and I didn't fine an easy way in the API to extract them).
  
  BUG: 387494

TEST PLAN
  (Most) translations are now available for the printer reported in the bug,
  and at least another printer.

REPOSITORY
  R363 Print Manager

BRANCH
  Applications/17.12

REVISION DETAIL
  https://phabricator.kde.org/D9996

AFFECTED FILES
  configure-printer/PrinterOptions.cpp

To: ltoscano, dantti
Cc: kde-utils-devel, #localization

[Attachment #3 (unknown)]

<table><tr><td style="">ltoscano created this revision.<br />ltoscano added a \
reviewer: dantti.<br />Restricted Application added a subscriber: kde-utils-devel.<br \
/>ltoscano requested review of this revision. </td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9996" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The to \
ppdLocalize() make sure that the translated strings in the PPD for<br /> the current \
language are returned instead of the untranslated string.</p>

<p>Unfortunately not all translations are returned, for example section<br />
titles are not translated (the translations are defined a bit differently<br />
in the PPD file and I didn&#039;t fine an easy way in the API to extract them).</p>

<p>BUG: 387494</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>(Most) \
translations are now available for the printer reported in the bug,<br /> and at \
least another printer.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R363 Print Manager</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>Applications/17.12</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9996" \
rel="noreferrer">https://phabricator.kde.org/D9996</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>configure-printer/PrinterOptions.cpp</div></div></div><br \
/><div><strong>To: </strong>ltoscano, dantti<br /><strong>Cc: \
</strong>kde-utils-devel, Localization<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]