[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-utils-devel
Subject: Re: Review Request 128059: Don't close the remove view if preferences are not shown
From: Urs Wolfer <uwolfer () kde ! org>
Date: 2016-05-31 19:29:10
Message-ID: 20160531192910.29452.68543 () mimi ! kde ! org
[Download RAW message or body]
--===============0061158980213840965==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128059/#review96107
-----------------------------------------------------------
Ship it!
Ship It!
- Urs Wolfer
On May 30, 2016, 4:16 p.m., Arno Möller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128059/
> -----------------------------------------------------------
>
> (Updated May 30, 2016, 4:16 p.m.)
>
>
> Review request for KDE Utils and Urs Wolfer.
>
>
> Repository: krdc
>
>
> Description
> -------
>
> The user already made it quite clear that he wants to open the remove view if we're here, so \
> don't close it again if he selected not to show the preferences dialog which is an option in \
> the preferences dialog itself, BTW...
>
> Diffs
> -----
>
> mainwindow.cpp dd1d8a0
>
> Diff: https://git.reviewboard.kde.org/r/128059/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arno Möller
>
>
--===============0061158980213840965==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128059/">https://git.reviewboard.kde.org/r/128059/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Urs Wolfer</p>
<br />
<p>On May 30th, 2016, 4:16 p.m. UTC, Arno Möller wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Utils and Urs Wolfer.</div>
<div>By Arno Möller.</div>
<p style="color: grey;"><i>Updated May 30, 2016, 4:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
krdc
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The user \
already made it quite clear that he wants to open the remove view if we're here, so don't close \
it again if he selected not to show the preferences dialog which is an option in the \
preferences dialog itself, BTW...</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mainwindow.cpp <span style="color: grey">(dd1d8a0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128059/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0061158980213840965==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic