'Re: Review Request 123832: libarchive: Improve the handling of archive_write_header() errors.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-utils-devel
Subject:    Re: Review Request 123832: libarchive: Improve the handling of archive_write_header() errors.
From:       Raphael Kubo da Costa <rakuco () FreeBSD ! org>
Date:       2016-01-15 12:20:49
Message-ID: 20160115122049.31213.22945 () mimi ! kde ! org
[Download RAW message or body]

--===============7164524026615031939==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123832/
-----------------------------------------------------------

(Updated Jan. 15, 2016, 2:20 p.m.)

Status
------

This change has been discarded.

Review request for KDE Utils and Raphael Kubo da Costa.

Bugs: 206383 and 335411
    http://bugs.kde.org/show_bug.cgi?id=206383
    http://bugs.kde.org/show_bug.cgi?id=335411

Repository: ark

Description
-------

Errors while extracting an archive entry in copyFiles() were being
discarded without informing the user, who would then believe the entire
extraction had worked correctly. We now emit the error() signal when
there is an error and cancel the extraction.

Other callers of archive_write_header() have also been modified to use
the same coding style (handling errors in a switch()) and error message
format for consistency and ease of future maintenance.

Additionally, none of the error messages use archive_error_string()
anymore. While this means the messages are less detailed, it also means
users who use a translated KDE will not see part of the error messages
hardcoded in English.

Diffs
-----

  plugins/libarchive/libarchivehandler.cpp 75cf759d5e67508288ee6a42d42b4c0d6b557afe 

Diff: https://git.reviewboard.kde.org/r/123832/diff/

Testing
-------

Creating archives still works as before, and error messages during extraction (such \
as the one in bug 335411) are properly reported.

Thanks,

Raphael Kubo da Costa

--===============7164524026615031939==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123832/">https://git.reviewboard.kde.org/r/123832/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Utils and Raphael Kubo da Costa.</div>
<div>By Raphael Kubo da Costa.</div>

<p style="color: grey;"><i>Updated Jan. 15, 2016, 2:20 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=206383">206383</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=335411">335411</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Errors while extracting an archive entry in \
copyFiles() were being discarded without informing the user, who would then believe \
the entire extraction had worked correctly. We now emit the error() signal when
there is an error and cancel the extraction.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Other callers of archive_write_header() have also been \
modified to use the same coding style (handling errors in a switch()) and error \
message format for consistency and ease of future maintenance.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Additionally, none of the error messages use \
archive_error_string() anymore. While this means the messages are less detailed, it \
also means users who use a translated KDE will not see part of the error messages
hardcoded in English.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Creating archives still works as before, and error \
messages during extraction (such as the one in bug 335411) are properly \
reported.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plugins/libarchive/libarchivehandler.cpp <span style="color: \
grey">(75cf759d5e67508288ee6a42d42b4c0d6b557afe)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123832/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7164524026615031939==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel

[prev in list] [next in list] [prev in thread] [next in thread] 