From kde-utils-devel Tue Dec 22 15:23:02 2015 From: "Rolf Eike Beer" Date: Tue, 22 Dec 2015 15:23:02 +0000 To: kde-utils-devel Subject: Re: Review Request 126470: Use SHARE_INSTALL_PREFIX to install appstream data Message-Id: <20151222152302.32218.79678 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-utils-devel&m=145079779223746 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5697419937202916308==" --===============5697419937202916308== Content-Type: multipart/alternative; boundary="===============3591830836914769375==" --===============3591830836914769375== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126470/#review89934 ----------------------------------------------------------- Ship it! Ship It! - Rolf Eike Beer On Dez. 22, 2015, 2:02 nachm., Heiko Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126470/ > ----------------------------------------------------------- > > (Updated Dez. 22, 2015, 2:02 nachm.) > > > Review request for KDE Utils and Rolf Eike Beer. > > > Repository: kgpg > > > Description > ------- > > ...instead of hard-coding share/.. which is not helpful on a multiarch > layout, where the prefix might be something like /usr/${arch} but arch > independent files should still go into /usr/share. > > > Diffs > ----- > > CMakeLists.txt a1c2189 > > Diff: https://git.reviewboard.kde.org/r/126470/diff/ > > > Testing > ------- > > kgpg.appdata.xml gets installed into the desired location > > > Thanks, > > Heiko Becker > > --===============3591830836914769375== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126470/

Ship it!

Ship It!

- Rolf Eike Beer

On Dezember 22nd, 2015, 2:02 nachm. UTC, Heiko Becker wrote:

Review request for KDE Utils and Rolf Eike Beer.

By Heiko Becker.

Updated Dez. 22, 2015, 2:02 nachm.

Repository: kgpg

Description

...instead of hard-coding share/.. which is not helpful on a multiarch
layout, where the prefix might be something like /usr/${arch} but arch
independent files should still go into /usr/share.

Testing

kgpg.appdata.xml gets installed into the desired location

Diffs

CMakeLists.txt (a1c2189)

View Diff

--===============3591830836914769375==-- --===============5697419937202916308== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KS2RlLXV0aWxz LWRldmVsIG1haWxpbmcgbGlzdApLZGUtdXRpbHMtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwu a2RlLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2tkZS11dGlscy1kZXZlbAo= --===============5697419937202916308==--