'Re: Review Request 126470: Use SHARE_INSTALL_PREFIX to install appstream data'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-utils-devel
Subject:    Re: Review Request 126470: Use SHARE_INSTALL_PREFIX to install appstream data
From:       "Heiko Becker" <heirecka () exherbo ! org>
Date:       2015-12-22 15:17:07
Message-ID: 20151222151707.32218.87293 () mimi ! kde ! org
[Download RAW message or body]

--===============7220239219758271534==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Dez. 22, 2015, 3:09 nachm., Rolf Eike Beer wrote:
> > Where does SHARE_INSTALL_PREFIX come from?

From kdelibs:
https://quickgit.kde.org/?p=kdelibs.git&a=blob&h=7d54b9b83b999f6a6e8541f8e8b89e0b2a105703&hb=016841aeb0b180981122085e9b1d49ae66951670&f=cmake%2Fmodules%2FFindKDE4Internal.cmake#l838

- Heiko

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126470/#review89931
-----------------------------------------------------------

On Dez. 22, 2015, 2:02 nachm., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126470/
> -----------------------------------------------------------
> 
> (Updated Dez. 22, 2015, 2:02 nachm.)
> 
> 
> Review request for KDE Utils and Rolf Eike Beer.
> 
> 
> Repository: kgpg
> 
> 
> Description
> -------
> 
> ...instead of hard-coding share/.. which is not helpful on a multiarch
> layout, where the prefix might be something like /usr/${arch} but arch
> independent files should still go into /usr/share.
> 
> 
> Diffs
> -----
> 
> CMakeLists.txt a1c2189 
> 
> Diff: https://git.reviewboard.kde.org/r/126470/diff/
> 
> 
> Testing
> -------
> 
> kgpg.appdata.xml gets installed into the desired location
> 
> 
> Thanks,
> 
> Heiko Becker
> 
> 

--===============7220239219758271534==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126470/">https://git.reviewboard.kde.org/r/126470/</a>
     </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On Dezember 22nd, 2015, 3:09 nachm. UTC, <b>Rolf Eike Beer</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Where does SHARE_INSTALL_PREFIX come from?</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">From kdelibs: \
https://quickgit.kde.org/?p=kdelibs.git&amp;a=blob&amp;h=7d54b9b83b999f6a6e8541f8e8b89e0b2a105703&amp;hb=0 \
16841aeb0b180981122085e9b1d49ae66951670&amp;f=cmake%2Fmodules%2FFindKDE4Internal.cmake#l838</pre> <br />

<p>- Heiko</p>

<br />
<p>On Dezember 22nd, 2015, 2:02 nachm. UTC, Heiko Becker wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Utils and Rolf Eike Beer.</div>
<div>By Heiko Becker.</div>

<p style="color: grey;"><i>Updated Dez. 22, 2015, 2:02 nachm.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kgpg
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">...instead of hard-coding share/.. which is \
not helpful on a multiarch layout, where the prefix might be something like /usr/${arch} but arch
independent files should still go into /usr/share.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kgpg.appdata.xml gets installed into the \
desired location</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(a1c2189)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126470/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7220239219758271534==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel

[prev in list] [next in list] [prev in thread] [next in thread] 