[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-utils-devel
Subject: Re: Review Request 126139: Port KDiskFree to KF5 / Qt5.
From: "Rolf Eike Beer" <kde () opensource ! sf-tec ! de>
Date: 2015-11-22 16:45:50
Message-ID: 20151122164550.14400.92941 () mimi ! kde ! org
[Download RAW message or body]
--===============8696290172716238637==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126139/#review88694
-----------------------------------------------------------
I suggest to do this in 2 steps, first e.g. port all kDebug() to qDebug(), which would work with both Qt \
versions. This makes the actual diff much smaller and easier to review.
Until now the Qt includes were below the KDE ones, probably to spot missing includes in the KDE headers. \
Please keep this order, and do not add sectioned Qt headers (i.e. remove "QtWidgets/" from the includes \
you add).
- Rolf Eike Beer
On Nov. 22, 2015, 4:34 nachm., Yoann Laissus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126139/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2015, 4:34 nachm.)
>
>
> Review request for KDE Utils.
>
>
> Repository: kdf
>
>
> Description
> -------
>
> A port of KDiskFree to KF5 / Qt5, without KDE4LibsSupport.
> Please let me know if everything is right, especially about the KMenu / KDialog migration.
>
> About the desktop files, are my changes corrects ? And what about the KCM one ?
>
>
> Diffs
> -----
>
> CMakeLists.txt ad591e70cbbb6d10fdf362f68bfa3764646ab662
> disklist.cpp 12e12353748bbc46db013b90b5292c0cfa8f6c2f
> disks.cpp 83f9729021fd24e2a19d333f5ef1503d7760e684
> doc/app/CMakeLists.txt 44bb820a89ee24d2dcd0bdf825cb64f8f4cc831e
> doc/kcontrol/CMakeLists.txt b0face2673997aad2193ea716634b7bad0c426ac
> kcmdf.cpp 36c379ec499f92bb3e1e26c79fba96ef410a6dda
> kcmdf.desktop 5e17fcc7eeb5ab9f1cd4cb759c4ee86a31526080
> kcmdf.h 1efa465f6e8fd028dbd2f0a95128849c657ca417
> kconftest.cpp 05d09d372a09f72be8134c77f956919d24182c9c
> kdf.cpp c1f8aa64526623a60b37c65319c6e933d66d3e35
> kdf.desktop dea9dfe0d7f0c0b91731dcd42eee0fa12ba6bb37
> kdfconfig.cpp f6fe25807d04db6b258f4ce0eb7f53e86adb522d
> kdfitemdelegate.h 1d5f25f1fd733b544966567ed8f211b3be048bca
> kdfitemdelegate.cpp 7c2eac559e7d64cfe13181cbd034b26a25133670
> kdfwidget.h d611a477253189cb9f785a81ac4ab56e53828574
> kdfwidget.cpp 9312365631e6e766e5700c57ec17b1064073ed67
> kwikdisk.h 39582d09f00bdaef3b0d61cc61f852cba0d8272c
> kwikdisk.cpp 713ebfc056c82a4101b736f46b4803e75db7e7e0
> kwikdisk.desktop a7b8200691da08eae6d3a79d9d8ff3e74e6f005a
> mntconfig.h ecb07f19eeef5b398f2e366bb2792cda94c35f69
> mntconfig.cpp 33cd92a9b3325dca4d4b2038b904f9ee8d16e71f
> mntconfig.ui 39cb679a2dff3e47f8cb3a29a766c941e1fe3035
> optiondialog.h e08f1168dc89ff24fff17cdfe600ed3c655646cd
> optiondialog.cpp 97d5e3fb75351abeb184064cae3578bdb39822b1
> pics/CMakeLists.txt 7affd27ee45de94f71ab2af5cab74f1a54bb9400
> pics/hi128-app-kdf.png
> pics/hi128-app-kwikdisk.png
> pics/hi16-app-kdf.png
> pics/hi16-app-kwikdisk.png
> pics/hi22-app-kdf.png
> pics/hi22-app-kwikdisk.png
> pics/hi32-app-kdf.png
> pics/hi32-app-kwikdisk.png
> pics/hi48-app-kdf.png
> pics/hi48-app-kwikdisk.png
> pics/hi64-app-kdf.png
> pics/hi64-app-kwikdisk.png
> pics/ox16-app-kcmdf.png
> pics/ox22-app-kcmdf.png
> pics/ox32-app-kcmdf.png
> stdoption.cpp fce7b894164cf5e8a0fde80353661919a2d5d045
>
> Diff: https://git.reviewboard.kde.org/r/126139/diff/
>
>
> Testing
> -------
>
> All features of KDiskFree tested.
>
>
> Thanks,
>
> Yoann Laissus
>
>
--===============8696290172716238637==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126139/">https://git.reviewboard.kde.org/r/126139/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I suggest to do this in 2 steps, first e.g. port all kDebug() to qDebug(), \
which would work with both Qt versions. This makes the actual diff much smaller and easier to review.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Until \
now the Qt includes were below the KDE ones, probably to spot missing includes in the KDE headers. Please \
keep this order, and do not add sectioned Qt headers (i.e. remove "QtWidgets/" from the includes you \
add).</p></pre> <br />
<p>- Rolf Eike Beer</p>
<br />
<p>On November 22nd, 2015, 4:34 nachm. UTC, Yoann Laissus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Utils.</div>
<div>By Yoann Laissus.</div>
<p style="color: grey;"><i>Updated Nov. 22, 2015, 4:34 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdf
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">A port of KDiskFree to KF5 / Qt5, without \
KDE4LibsSupport. Please let me know if everything is right, especially about the KMenu / KDialog \
migration.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">About the desktop files, are my changes corrects ? And what about the KCM one ?</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">All features of KDiskFree tested.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(ad591e70cbbb6d10fdf362f68bfa3764646ab662)</span></li>
<li>disklist.cpp <span style="color: grey">(12e12353748bbc46db013b90b5292c0cfa8f6c2f)</span></li>
<li>disks.cpp <span style="color: grey">(83f9729021fd24e2a19d333f5ef1503d7760e684)</span></li>
<li>doc/app/CMakeLists.txt <span style="color: \
grey">(44bb820a89ee24d2dcd0bdf825cb64f8f4cc831e)</span></li>
<li>doc/kcontrol/CMakeLists.txt <span style="color: \
grey">(b0face2673997aad2193ea716634b7bad0c426ac)</span></li>
<li>kcmdf.cpp <span style="color: grey">(36c379ec499f92bb3e1e26c79fba96ef410a6dda)</span></li>
<li>kcmdf.desktop <span style="color: grey">(5e17fcc7eeb5ab9f1cd4cb759c4ee86a31526080)</span></li>
<li>kcmdf.h <span style="color: grey">(1efa465f6e8fd028dbd2f0a95128849c657ca417)</span></li>
<li>kconftest.cpp <span style="color: grey">(05d09d372a09f72be8134c77f956919d24182c9c)</span></li>
<li>kdf.cpp <span style="color: grey">(c1f8aa64526623a60b37c65319c6e933d66d3e35)</span></li>
<li>kdf.desktop <span style="color: grey">(dea9dfe0d7f0c0b91731dcd42eee0fa12ba6bb37)</span></li>
<li>kdfconfig.cpp <span style="color: grey">(f6fe25807d04db6b258f4ce0eb7f53e86adb522d)</span></li>
<li>kdfitemdelegate.h <span style="color: grey">(1d5f25f1fd733b544966567ed8f211b3be048bca)</span></li>
<li>kdfitemdelegate.cpp <span style="color: grey">(7c2eac559e7d64cfe13181cbd034b26a25133670)</span></li>
<li>kdfwidget.h <span style="color: grey">(d611a477253189cb9f785a81ac4ab56e53828574)</span></li>
<li>kdfwidget.cpp <span style="color: grey">(9312365631e6e766e5700c57ec17b1064073ed67)</span></li>
<li>kwikdisk.h <span style="color: grey">(39582d09f00bdaef3b0d61cc61f852cba0d8272c)</span></li>
<li>kwikdisk.cpp <span style="color: grey">(713ebfc056c82a4101b736f46b4803e75db7e7e0)</span></li>
<li>kwikdisk.desktop <span style="color: grey">(a7b8200691da08eae6d3a79d9d8ff3e74e6f005a)</span></li>
<li>mntconfig.h <span style="color: grey">(ecb07f19eeef5b398f2e366bb2792cda94c35f69)</span></li>
<li>mntconfig.cpp <span style="color: grey">(33cd92a9b3325dca4d4b2038b904f9ee8d16e71f)</span></li>
<li>mntconfig.ui <span style="color: grey">(39cb679a2dff3e47f8cb3a29a766c941e1fe3035)</span></li>
<li>optiondialog.h <span style="color: grey">(e08f1168dc89ff24fff17cdfe600ed3c655646cd)</span></li>
<li>optiondialog.cpp <span style="color: grey">(97d5e3fb75351abeb184064cae3578bdb39822b1)</span></li>
<li>pics/CMakeLists.txt <span style="color: grey">(7affd27ee45de94f71ab2af5cab74f1a54bb9400)</span></li>
<li>pics/hi128-app-kdf.png <span style="color: grey">()</span></li>
<li>pics/hi128-app-kwikdisk.png <span style="color: grey">()</span></li>
<li>pics/hi16-app-kdf.png <span style="color: grey">()</span></li>
<li>pics/hi16-app-kwikdisk.png <span style="color: grey">()</span></li>
<li>pics/hi22-app-kdf.png <span style="color: grey">()</span></li>
<li>pics/hi22-app-kwikdisk.png <span style="color: grey">()</span></li>
<li>pics/hi32-app-kdf.png <span style="color: grey">()</span></li>
<li>pics/hi32-app-kwikdisk.png <span style="color: grey">()</span></li>
<li>pics/hi48-app-kdf.png <span style="color: grey">()</span></li>
<li>pics/hi48-app-kwikdisk.png <span style="color: grey">()</span></li>
<li>pics/hi64-app-kdf.png <span style="color: grey">()</span></li>
<li>pics/hi64-app-kwikdisk.png <span style="color: grey">()</span></li>
<li>pics/ox16-app-kcmdf.png <span style="color: grey">()</span></li>
<li>pics/ox22-app-kcmdf.png <span style="color: grey">()</span></li>
<li>pics/ox32-app-kcmdf.png <span style="color: grey">()</span></li>
<li>stdoption.cpp <span style="color: grey">(fce7b894164cf5e8a0fde80353661919a2d5d045)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126139/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8696290172716238637==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic