'Re: Review Request 126077: Port kfloppy away from using KDE3Support'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-utils-devel
Subject:    Re: Review Request 126077: Port kfloppy away from using KDE3Support
From:       "Wolfgang Bauer" <wbauer () tmo ! at>
Date:       2015-11-17 13:39:12
Message-ID: 20151117133912.14400.70388 () mimi ! kde ! org
[Download RAW message or body]

--===============8822186485100805496==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126077/
-----------------------------------------------------------

(Updated Nov. 17, 2015, 1:39 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Utils.

Changes
-------

Submitted with commit dd16fd84f22dfe4945234e3fbfddd22cb5073f0c by Wolfgang \
Bauer to branch Applications/15.12.

Repository: kfloppy

Description
-------

This replaces all usage of K3Process (used to run the external programs) \
with KProcess. That's the first step in porting kfloppy to KF5.

Diffs
-----

  CMakeLists.txt 9c1e410 
  format.h 0d51aa0 
  format.cpp 20b6d32 

Diff: https://git.reviewboard.kde.org/r/126077/diff/

Testing
-------

It still builds fine.

I formatted a few floppy disks, the external programs were called, the \
floppy disks got formatted, and the progress bar worked too.

Error messages when the needed tools are not available or the device cannot \
be accessed showed up as well.

Thanks,

Wolfgang Bauer

--===============8822186485100805496==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126077/">https://git.reviewboard.kde.org/r/126077/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px \
gray solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Utils.</div>
<div>By Wolfgang Bauer.</div>

<p style="color: grey;"><i>Updated Nov. 17, 2015, 1:39 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: \
1.5em;">Changes</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit dd16fd84f22dfe4945234e3fbfddd22cb5073f0c \
by Wolfgang Bauer to branch Applications/15.12.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kfloppy
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This replaces all usage of \
K3Process (used to run the external programs) with KProcess. That's the \
first step in porting kfloppy to KF5.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">It still builds fine.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I formatted a few floppy disks, the external \
programs were called, the floppy disks got formatted, and the progress bar \
worked too.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Error messages when the \
needed tools are not available or the device cannot be accessed showed up \
as well.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(9c1e410)</span></li>

 <li>format.h <span style="color: grey">(0d51aa0)</span></li>

 <li>format.cpp <span style="color: grey">(20b6d32)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126077/diff/" \
style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8822186485100805496==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel

[prev in list] [next in list] [prev in thread] [next in thread] 