[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-utils-devel
Subject: Re: Review Request 125072: Fix build on OS X
From: "Raphael Kubo da Costa" <rakuco () FreeBSD ! org>
Date: 2015-09-08 9:01:22
Message-ID: 20150908090122.24667.70104 () mimi ! kde ! org
[Download RAW message or body]
--===============5995478833016414701==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 6, 2015, 1:07 p.m., Raphael Kubo da Costa wrote:
> > I'm not the right person to review this. Please add the "kdeutils" group to the \
> > review request and CC Valentin Rusu, kwalletmanager's maintainer.
> > Additionally, the .reviewboardrc part of this patch is unrelated with the rest, \
> > so it would be good if you sent it separately.
>
> Samuel Gaist wrote:
> Sorry, I picked you since you where the first listed on \
> https://projects.kde.org/projects/kde/kdeutils/kwalletmanager
> The .reviewboardrc is a different patch. I haven't found yet how to create \
> separeted reviews from a series of commits (or if it's possible to show here that \
> they are separated stuff).
I would just send the .reviewboardrc part separately without worrying about series of \
commits (since they are not dependent anyway): just have two branches created from \
master and submit them separately.
- Raphael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125072/#review84892
-----------------------------------------------------------
On Sept. 8, 2015, 12:56 a.m., Samuel Gaist wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125072/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2015, 12:56 a.m.)
>
>
> Review request for KDE Utils and Valentin Rusu.
>
>
> Repository: kwalletmanager
>
>
> Description
> -------
>
> like msvc, clang doesn't know about __uid_t, this patch adds it to the list
>
>
> Diffs
> -----
>
> .reviewboardrc PRE-CREATION
> src/konfigurator/savehelper.cpp 143142e4825c07973a72496d643881122ec5a2f3
>
> Diff: https://git.reviewboard.kde.org/r/125072/diff/
>
>
> Testing
> -------
>
> Build on OS X 10.8
>
>
> Thanks,
>
> Samuel Gaist
>
>
--===============5995478833016414701==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125072/">https://git.reviewboard.kde.org/r/125072/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 6th, 2015, 1:07 p.m. EEST, <b>Raphael \
Kubo da Costa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I'm not the right person to review this. Please add \
the "kdeutils" group to the review request and CC Valentin Rusu, kwalletmanager's \
maintainer.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Additionally, the .reviewboardrc part of this patch is \
unrelated with the rest, so it would be good if you sent it separately.</p></pre> \
</blockquote>
<p>On September 6th, 2015, 10:39 p.m. EEST, <b>Samuel Gaist</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Sorry, I picked you since you where the first listed on \
https://projects.kde.org/projects/kde/kdeutils/kwalletmanager</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
.reviewboardrc is a different patch. I haven't found yet how to create separeted \
reviews from a series of commits (or if it's possible to show here that they are \
separated stuff).</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
would just send the .reviewboardrc part separately without worrying about series of \
commits (since they are not dependent anyway): just have two branches created from \
master and submit them separately.</p></pre> <br />
<p>- Raphael</p>
<br />
<p>On September 8th, 2015, 12:56 a.m. EEST, Samuel Gaist wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Utils and Valentin Rusu.</div>
<div>By Samuel Gaist.</div>
<p style="color: grey;"><i>Updated Sept. 8, 2015, 12:56 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwalletmanager
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">like msvc, clang doesn't know about __uid_t, this \
patch adds it to the list</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Build on OS X 10.8</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>.reviewboardrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/konfigurator/savehelper.cpp <span style="color: \
grey">(143142e4825c07973a72496d643881122ec5a2f3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125072/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5995478833016414701==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic