'Re: Review Request 123980: [Ark] Improve hide/show logic for information panel'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-utils-devel
Subject:    Re: Review Request 123980: [Ark] Improve hide/show logic for information panel
From:       "Raphael Kubo da Costa" <rakuco () FreeBSD ! org>
Date:       2015-06-04 11:09:19
Message-ID: 20150604110919.8350.52971 () mimi ! kde ! org
[Download RAW message or body]

--===============8557427138543305168==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123980/#review81175
-----------------------------------------------------------

Ship it!

Looks great now, thanks! I hadn't realized we were storing two separate IntLists \
already.

- Raphael Kubo da Costa

On June 4, 2015, 11:20 a.m., Ragnar Thomsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123980/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 11:20 a.m.)
> 
> 
> Review request for KDE Utils, Elvis Angelaccio and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> The logic governing hiding/showing of the infopanel as well as storing/retrieving \
> the size of the QSplitter was reworked into a more intuitive and simple approach. A \
> configuration option "showInfoPanel" of type bool was added, which stores whether \
> or not the infopanel should be shown. The option "splitterSizesWithBothWidgets" was \
> removed, since it's no longer needed. Default values of "splitterSizes" are now set \
> in the kcfg file, instead of in the C++ code. 
> 
> Diffs
> -----
> 
> kerfuffle/ark.kcfg 0c22014 
> part/part.h 6afd90f 
> part/part.cpp 7261631 
> 
> Diff: https://git.reviewboard.kde.org/r/123980/diff/
> 
> 
> Testing
> -------
> 
> Show/hide the information panel via the Settings menu works as expected. Ark \
> remembers whether or not it was shown after closing/opening the program. The sizes \
> of the splitter are also remembered after hiding/showing and after program restart. \
> Deleting the splitterSizes line in ~/.config/arkrc and opening Ark results in the \
> default sizes of 200/100 being used. 
> 
> Thanks,
> 
> Ragnar Thomsen
> 
> 

--===============8557427138543305168==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123980/">https://git.reviewboard.kde.org/r/123980/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks \
great now, thanks! I hadn't realized we were storing two separate IntLists \
already.</p></pre>  <br />

<p>- Raphael Kubo da Costa</p>

<br />
<p>On June 4th, 2015, 11:20 a.m. EEST, Ragnar Thomsen wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Utils, Elvis Angelaccio and Raphael Kubo da Costa.</div>
<div>By Ragnar Thomsen.</div>

<p style="color: grey;"><i>Updated June 4, 2015, 11:20 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The logic governing hiding/showing of the infopanel as \
well as storing/retrieving the size of the QSplitter was reworked into a more \
intuitive and simple approach. A configuration option "showInfoPanel" of type bool \
was added, which stores whether or not the infopanel should be shown. The option \
"splitterSizesWithBothWidgets" was removed, since it's no longer needed. Default \
values of "splitterSizes" are now set in the kcfg file, instead of in the C++ \
code.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Show/hide the information panel via the Settings menu \
works as expected. Ark remembers whether or not it was shown after closing/opening \
the program. The sizes of the splitter are also remembered after hiding/showing and \
after program restart. Deleting the splitterSizes line in ~/.config/arkrc and opening \
Ark results in the default sizes of 200/100 being used.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kerfuffle/ark.kcfg <span style="color: grey">(0c22014)</span></li>

 <li>part/part.h <span style="color: grey">(6afd90f)</span></li>

 <li>part/part.cpp <span style="color: grey">(7261631)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123980/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8557427138543305168==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel

[prev in list] [next in list] [prev in thread] [next in thread] 