[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-utils-devel
Subject: Re: Review Request 123980: [Ark] Fix the information panel
From: "Raphael Kubo da Costa" <rakuco () FreeBSD ! org>
Date: 2015-06-03 12:12:48
Message-ID: 20150603121248.8350.26988 () mimi ! kde ! org
[Download RAW message or body]
--===============4406746851732889371==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On June 2, 2015, 7:43 p.m., Raphael Kubo da Costa wrote:
> > Separating bug fixes from new features is always wise.
> >
> > In this case, the problem your other commit introduced can be fixed by just \
> > calling `QSplitter::setSizes()` after adding the widgets, just like it was done \
> > before. Suddenly your patch gets much smaller, self-contained and with much fewer \
> > risk of introducing new bugs :-)
> > Once we have something that is finally working properly, we can worry about other \
> > changes like switching from an IntList to a boolean and things like that.
>
> Ragnar Thomsen wrote:
> Thanks, I'll remember that for the next time :)
Actually, I'd like to do it this time to avoid introducing new bugs. A new RR could \
fix the bug, and this one just introduces these cosmetic changes to the code that are \
not that urgent.
> On June 2, 2015, 7:43 p.m., Raphael Kubo da Costa wrote:
> > part/part.cpp, lines 159-160
> > <https://git.reviewboard.kde.org/r/123980/diff/1/?file=378629#file378629line159>
> >
> > Why not do this in `saveSplitterSizes()`?
>
> Ragnar Thomsen wrote:
> I thought about that, but it didnt feel logical to put it under a function named \
> saveSplitterSizes. I can move it if you think it belongs there.
If the problem's the function name, we can rename it to something that makes more \
sense with the new code -- my point is that it is better to put all the code saving \
the splitter settings in one place (right now we're calling `ArkSettings::save()` in \
two different places, for example).
- Raphael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123980/#review81083
-----------------------------------------------------------
On June 2, 2015, 9:09 p.m., Ragnar Thomsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123980/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 9:09 p.m.)
>
>
> Review request for KDE Utils, Elvis Angelaccio and Raphael Kubo da Costa.
>
>
> Repository: ark
>
>
> Description
> -------
>
> The logic governing hiding/showing of the infopanel as well as storing/retrieving \
> the size of the QSplitter was reworked into a more intuitive and simple approach. A \
> configuration option "showInfoPanel" of type bool was added, which stores whether \
> or not the infopanel should be shown. The option "splitterSizesWithBothWidgets" was \
> removed, since it's no longer needed. Default values of "splitterSizes" are now set \
> in the kcfg file, instead of in the C++ code.
> The infopanel show/hide logic has been broken in the frameworks branch since this \
> commit: [b1ce0d272cff155fff54ca6d7cb90f90b9075490](http://quickgit.kde.org/?p=ark.git&a=commit&h=b1ce0d272cff155fff54ca6d7cb90f90b9075490)
>
>
> Diffs
> -----
>
> kerfuffle/ark.kcfg 97d2086
> part/part.h 6afd90f
> part/part.cpp 6fc9f55
>
> Diff: https://git.reviewboard.kde.org/r/123980/diff/
>
>
> Testing
> -------
>
> Show/hide the information panel via the Settings menu works as expected. Ark \
> remembers whether or not it was shown after closing/opening the program. The sizes \
> of the splitter are also remembered after hiding/showing and after program restart. \
> Deleting the splitterSizes line in ~/.config/arkrc and opening Ark results in the \
> default sizes of 200/100 being used.
>
> Thanks,
>
> Ragnar Thomsen
>
>
--===============4406746851732889371==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123980/">https://git.reviewboard.kde.org/r/123980/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 2nd, 2015, 7:43 p.m. EEST, <b>Raphael Kubo \
da Costa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Separating bug fixes from new features is always \
wise.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In this case, the problem your other commit introduced \
can be fixed by just calling <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">QSplitter::setSizes()</code> after adding the widgets, just like it was \
done before. Suddenly your patch gets much smaller, self-contained and with much \
fewer risk of introducing new bugs :-)</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Once we have something \
that is finally working properly, we can worry about other changes like switching \
from an IntList to a boolean and things like that.</p></pre> </blockquote>
<p>On June 2nd, 2015, 9:09 p.m. EEST, <b>Ragnar Thomsen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks, I'll remember that for the next time :)</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Actually, I'd like to do it this time to avoid introducing new bugs. A new \
RR could fix the bug, and this one just introduces these cosmetic changes to the code \
that are not that urgent.</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 2nd, 2015, 7:43 p.m. EEST, <b>Raphael Kubo \
da Costa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123980/diff/1/?file=378629#file378629line159" \
style="color: black; font-weight: bold; text-decoration: \
underline;">part/part.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">Part::Part(QWidget *parentWidget, QObject *parent, const QVariantList& \
args)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">153</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">ArkSettings</span><span class="o">::</span><span \
class="n">setShowInfoPanel</span><span class="p">(</span><span \
class="n">showInfoPanelAction</span><span class="o">-></span><span \
class="n">isChecked</span><span class="p">());</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">154</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">ArkSettings</span><span class="o">::</span><span class="n">self</span><span \
class="p">()</span><span class="o">-></span><span class="n">save</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why \
not do this in <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: \
inherit;">saveSplitterSizes()</code>?</p></pre> </blockquote>
<p>On June 2nd, 2015, 9:09 p.m. EEST, <b>Ragnar Thomsen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
thought about that, but it didnt feel logical to put it under a function named \
saveSplitterSizes. I can move it if you think it belongs there.</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">If the problem's the function name, we can rename it to something that \
makes more sense with the new code -- my point is that it is better to put all the \
code saving the splitter settings in one place (right now we're calling <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">ArkSettings::save()</code> in two different places, for \
example).</p></pre> <br />
<p>- Raphael</p>
<br />
<p>On June 2nd, 2015, 9:09 p.m. EEST, Ragnar Thomsen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Utils, Elvis Angelaccio and Raphael Kubo da Costa.</div>
<div>By Ragnar Thomsen.</div>
<p style="color: grey;"><i>Updated June 2, 2015, 9:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The logic governing hiding/showing of the infopanel as \
well as storing/retrieving the size of the QSplitter was reworked into a more \
intuitive and simple approach. A configuration option "showInfoPanel" of type bool \
was added, which stores whether or not the infopanel should be shown. The option \
"splitterSizesWithBothWidgets" was removed, since it's no longer needed. Default \
values of "splitterSizes" are now set in the kcfg file, instead of in the C++ \
code.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The infopanel show/hide logic has been broken in the \
frameworks branch since this commit: <a \
href="http://quickgit.kde.org/?p=ark.git&a=commit&h=b1ce0d272cff155fff54ca6d7cb90f90b9075490" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">b1ce0d272cff155fff54ca6d7cb90f90b9075490</a></p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Show/hide the information panel via the Settings menu \
works as expected. Ark remembers whether or not it was shown after closing/opening \
the program. The sizes of the splitter are also remembered after hiding/showing and \
after program restart. Deleting the splitterSizes line in ~/.config/arkrc and opening \
Ark results in the default sizes of 200/100 being used.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kerfuffle/ark.kcfg <span style="color: grey">(97d2086)</span></li>
<li>part/part.h <span style="color: grey">(6afd90f)</span></li>
<li>part/part.cpp <span style="color: grey">(6fc9f55)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123980/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4406746851732889371==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic