[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-utils-devel
Subject: Re: Review Request 121231: ark: suppress preview on large files
From: "Raphael Kubo da Costa" <rakuco () FreeBSD ! org>
Date: 2015-06-03 11:46:54
Message-ID: 20150603114654.8350.71760 () mimi ! kde ! org
[Download RAW message or body]
--===============8291718252025589500==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On June 3, 2015, 2:11 p.m., Raphael Kubo da Costa wrote:
> > New settings are introduced but there's no UI to control their values, right? In \
> > that case, isn't it better to just check the file size and ask the user before \
> > previewing?
>
> Ragnar Thomsen wrote:
> I think we should merge the "Configuration dialog" \
> (https://git.reviewboard.kde.org/r/121997/) before 15.08. In that case there will \
> be a UI to control the values...
> Elvis Angelaccio wrote:
> Yes, I could update the settings dialog's RR to actually introduce these new \
> settings.
> Ragnar Thomsen wrote:
> Great Elvis. [121997](https://git.reviewboard.kde.org/r/121997/) also needs \
> rebasing against frameworks branch. Do you have time for this? Otherwise I could \
> help...
> Raphael Kubo da Costa wrote:
> Either that or changing this RR... Right now the worst order was chosen and right \
> now users will just be surprised that some files will not be previewed.
> Ragnar Thomsen wrote:
> But "users" are supposed to be running released versions of Ark.
If you land feature B that should have been committed after feature A which has not \
landed yet, there's always a risk that a deadline is missed and we ship something \
incomplete to the users. This is probably not going to be the case here since you and \
Elvis seem to have the time and energy to get everything ready, but I wouldn't like \
to start doing that for other features too.
- Raphael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121231/#review81112
-----------------------------------------------------------
On June 3, 2015, 2:28 p.m., Boris Egorov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121231/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 2:28 p.m.)
>
>
> Review request for KDE Utils and Raphael Kubo da Costa.
>
>
> Bugs: 139389
> http://bugs.kde.org/show_bug.cgi?id=139389
>
>
> Repository: ark
>
>
> Description
> -------
>
> Do not preview large files
>
>
> Diffs
> -----
>
> kerfuffle/ark.kcfg 97d2086
> part/part.cpp 87afb49
>
> Diff: https://git.reviewboard.kde.org/r/121231/diff/
>
>
> Testing
> -------
>
> Build ark, make sure that files larger than specified limit is not previewed.
>
>
> Thanks,
>
> Boris Egorov
>
>
--===============8291718252025589500==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121231/">https://git.reviewboard.kde.org/r/121231/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 3rd, 2015, 2:11 p.m. EEST, <b>Raphael Kubo \
da Costa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">New settings are introduced but there's no UI to \
control their values, right? In that case, isn't it better to just check the file \
size and ask the user before previewing?</p></pre> </blockquote>
<p>On June 3rd, 2015, 2:17 p.m. EEST, <b>Ragnar Thomsen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think we should merge the "Configuration dialog" \
(https://git.reviewboard.kde.org/r/121997/) before 15.08. In that case there will be \
a UI to control the values...</p></pre> </blockquote>
<p>On June 3rd, 2015, 2:19 p.m. EEST, <b>Elvis Angelaccio</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, \
I could update the settings dialog's RR to actually introduce these new \
settings.</p></pre> </blockquote>
<p>On June 3rd, 2015, 2:27 p.m. EEST, <b>Ragnar Thomsen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Great \
Elvis. <a href="https://git.reviewboard.kde.org/r/121997/" style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">121997</a> also needs rebasing against frameworks branch. Do you have time \
for this? Otherwise I could help...</p></pre> </blockquote>
<p>On June 3rd, 2015, 2:33 p.m. EEST, <b>Raphael Kubo da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Either that or changing this RR... Right now the worst order was chosen and \
right now users will just be surprised that some files will not be \
previewed.</p></pre> </blockquote>
<p>On June 3rd, 2015, 2:37 p.m. EEST, <b>Ragnar Thomsen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But \
"users" are supposed to be running released versions of Ark.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If \
you land feature B that should have been committed after feature A which has not \
landed yet, there's always a risk that a deadline is missed and we ship something \
incomplete to the users. This is probably not going to be the case here since you and \
Elvis seem to have the time and energy to get everything ready, but I wouldn't like \
to start doing that for other features too.</p></pre> <br />
<p>- Raphael</p>
<br />
<p>On June 3rd, 2015, 2:28 p.m. EEST, Boris Egorov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Utils and Raphael Kubo da Costa.</div>
<div>By Boris Egorov.</div>
<p style="color: grey;"><i>Updated June 3, 2015, 2:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=139389">139389</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Do not preview large files</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Build ark, make sure that files larger than specified \
limit is not previewed.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kerfuffle/ark.kcfg <span style="color: grey">(97d2086)</span></li>
<li>part/part.cpp <span style="color: grey">(87afb49)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121231/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8291718252025589500==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic