[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-utils-devel
Subject: Re: Review Request 123967: Change argument of ReadOnlyArchiveInterface::finished() to fix cancellati
From: "Raphael Kubo da Costa" <rakuco () FreeBSD ! org>
Date: 2015-05-31 20:18:43
Message-ID: 20150531201843.8350.72578 () mimi ! kde ! org
[Download RAW message or body]
--===============1755122825795981013==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123967/#review81016
-----------------------------------------------------------
part/part.cpp (line 507)
<https://git.reviewboard.kde.org/r/123967/#comment55480>
Minor nitpick: if you are splitting the call like this, this line and the next \
one should be below "@info", since they are arguments to `xi18nc()`, not \
`KMessageBox::error()`.
- Raphael Kubo da Costa
On May 31, 2015, 11:16 p.m., Ragnar Thomsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123967/
> -----------------------------------------------------------
>
> (Updated May 31, 2015, 11:16 p.m.)
>
>
> Review request for KDE Utils, Elvis Angelaccio and Raphael Kubo da Costa.
>
>
> Bugs: 267670
> http://bugs.kde.org/show_bug.cgi?id=267670
>
>
> Repository: ark
>
>
> Description
> -------
>
> Change the argument of the ReadOnlyArchiveInterface::finished() from bool to a new \
> enum with the possible values: Success, Cancelled and ProgramNotFound. Similarly \
> change the argument of the Job::onFinished() slot. This way CliInterface can send a \
> finished() signal with the Cancelled argument. Job handles the finished signal in \
> the OnFinished() slot and sets the KJob::error() to KJob::KilledJobError if \
> argument is "Cancelled". The callers (Part and BatchExtract) are modified to do \
> nothing if the error code is KJob::KilledJobError. This fixes an issue where the \
> user cancels the "Enter password" dialog and the UI keeps being blocked and/or \
> error messageboxes appear.
> The commit ee006cb6a83e6cbd01a2dc459b8b0c8be664c05e in the frameworks branch should \
> be reverted before applying this diff, since this is meant to be an improved \
> replacement of that commit.
>
> Diffs
> -----
>
> kerfuffle/archiveinterface.h 3126a4c
> kerfuffle/cliinterface.cpp 089f36c
> kerfuffle/jobs.h 5e177d3
> kerfuffle/jobs.cpp 061b75e
> part/part.cpp fa1688e
>
> Diff: https://git.reviewboard.kde.org/r/123967/diff/
>
>
> Testing
> -------
>
> Opened a password-protected zip archive, clicked on a file and cancelled the \
> dialog. Opened a password-protected zip archive, selected a file for extraction and \
> cancelled the password dialog. Opened a password-protected rar archive, and \
> cancelled the password dialog. In all cases, the UI is not blocked after cancelling \
> the dialog and no message boxes appear.
>
> Thanks,
>
> Ragnar Thomsen
>
>
--===============1755122825795981013==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123967/">https://git.reviewboard.kde.org/r/123967/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123967/diff/3/?file=378534#file378534line507" \
style="color: black; font-weight: bold; text-decoration: \
underline;">part/part.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Part::slotLoadingStarted()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">507</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">localFilePath</span><span class="p">(),</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Minor \
nitpick: if you are splitting the call like this, this line and the next one should \
be below "@info", since they are arguments to <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">xi18nc()</code>, not <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">KMessageBox::error()</code>.</p></pre> </div>
</div>
<br />
<p>- Raphael Kubo da Costa</p>
<br />
<p>On May 31st, 2015, 11:16 p.m. EEST, Ragnar Thomsen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Utils, Elvis Angelaccio and Raphael Kubo da Costa.</div>
<div>By Ragnar Thomsen.</div>
<p style="color: grey;"><i>Updated May 31, 2015, 11:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=267670">267670</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Change the argument of the \
ReadOnlyArchiveInterface::finished() from bool to a new enum with the possible \
values: Success, Cancelled and ProgramNotFound. Similarly change the argument of the \
Job::onFinished() slot. This way CliInterface can send a finished() signal with the \
Cancelled argument. Job handles the finished signal in the OnFinished() slot and sets \
the KJob::error() to KJob::KilledJobError if argument is "Cancelled". The callers \
(Part and BatchExtract) are modified to do nothing if the error code is \
KJob::KilledJobError. This fixes an issue where the user cancels the "Enter password" \
dialog and the UI keeps being blocked and/or error messageboxes appear.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The commit ee006cb6a83e6cbd01a2dc459b8b0c8be664c05e in the frameworks \
branch should be reverted before applying this diff, since this is meant to be an \
improved replacement of that commit.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Opened a password-protected zip archive, clicked on a \
file and cancelled the dialog. Opened a password-protected zip archive, selected a \
file for extraction and cancelled the password dialog. Opened a password-protected \
rar archive, and cancelled the password dialog. In all cases, the UI is not blocked \
after cancelling the dialog and no message boxes appear.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kerfuffle/archiveinterface.h <span style="color: grey">(3126a4c)</span></li>
<li>kerfuffle/cliinterface.cpp <span style="color: grey">(089f36c)</span></li>
<li>kerfuffle/jobs.h <span style="color: grey">(5e177d3)</span></li>
<li>kerfuffle/jobs.cpp <span style="color: grey">(061b75e)</span></li>
<li>part/part.cpp <span style="color: grey">(fa1688e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123967/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1755122825795981013==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic