'Re: Review Request 122376: libarchive: throw error on extracting fail'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-utils-devel
Subject:    Re: Review Request 122376: libarchive: throw error on extracting fail
From:       "Raphael Kubo da Costa" <rakuco () FreeBSD ! org>
Date:       2015-05-31 14:41:04
Message-ID: 20150531144104.8350.10468 () mimi ! kde ! org
[Download RAW message or body]

--===============4839756937895701705==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122376/#review81009
-----------------------------------------------------------

Thanks for the patch. I am trying to handle this problem more generically in the \
libarchive code in review request 123832. I believe it supercedes the work done here.

- Raphael Kubo da Costa

On Feb. 2, 2015, 11:08 a.m., Boris Egorov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122376/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2015, 11:08 a.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 206383
> http://bugs.kde.org/show_bug.cgi?id=206383
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> Ark can't continue extraction after libarchive fail anyway, so let's instead throw \
> an error. Such error can appear when disk is full, for example. Error progpagated \
> to UI and shown to user. Error message currently a little verbose ("Cannot extract \
> file.txt: Can't create 'file.txt'") for now. 
> 
> Diffs
> -----
> 
> plugins/libarchive/libarchivehandler.cpp 0fba528 
> 
> Diff: https://git.reviewboard.kde.org/r/122376/diff/
> 
> 
> Testing
> -------
> 
> Make sure build is fine, then:
> 
> dd if=/dev/zero of=linux-ark bs=1024 count=100
> sudo mke2fs linux-ark
> sudo mount tmp/linux-ark /mnt/
> cd /mnt
> mkdir extract
> ark -b -o extract /path/to/some/archive.zip
> 
> 
> Thanks,
> 
> Boris Egorov
> 
> 

--===============4839756937895701705==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122376/">https://git.reviewboard.kde.org/r/122376/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks for the patch. I am trying to handle this problem more generically \
in the libarchive code in review request 123832. I believe it supercedes the work \
done here.</p></pre>  <br />

<p>- Raphael Kubo da Costa</p>

<br />
<p>On February 2nd, 2015, 11:08 a.m. EET, Boris Egorov wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Utils and Raphael Kubo da Costa.</div>
<div>By Boris Egorov.</div>

<p style="color: grey;"><i>Updated Feb. 2, 2015, 11:08 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=206383">206383</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ark can't continue extraction after libarchive fail \
anyway, so let's instead throw an error. Such error can appear when disk is full, for \
example. Error progpagated to UI and shown to user. Error message currently a little \
verbose ("Cannot extract file.txt: Can't create 'file.txt'") for now.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Make sure build is fine, then:</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">dd \
if=/dev/zero of=linux-ark bs=1024 count=100 sudo mke2fs linux-ark
sudo mount tmp/linux-ark /mnt/
cd /mnt
mkdir extract
ark -b -o extract /path/to/some/archive.zip</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plugins/libarchive/libarchivehandler.cpp <span style="color: \
grey">(0fba528)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122376/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4839756937895701705==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel

[prev in list] [next in list] [prev in thread] [next in thread] 