[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-utils-devel
Subject: Re: Review Request 122897: Fix 7z zip not listing files after adding on new created archive.
From: "Raphael Kubo da Costa" <rakuco () FreeBSD ! org>
Date: 2015-03-22 23:04:25
Message-ID: 20150322230425.548.98821 () mimi ! kde ! org
[Download RAW message or body]
--===============1275250421188196285==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On March 17, 2015, 11:58 a.m., Raphael Kubo da Costa wrote:
> > Thanks a lot for the patch and sorry for being absent.
> > Does this mean Ark is currently unable to add/remove files from 7z archives, or \
> > is it that the file list is not updated after that is done? Are you using the new \
> > p7zip (9.38.1)?
>
> Giuseppe Silletti wrote:
> It is that the file list is not updated after adding a file. I'm using the last \
> version of p7zip.
> Raphael Kubo da Costa wrote:
> I've just tried Ark here (latest `master`) with p7zip 9.38.1. I had an archive with \
> a single file in it. I was able to add two new files and remove them, and the file \
> list was updated correctly. Can you file a bug report and attach a file and some \
> steps showing I could reproduce the issue you are having?
> Giuseppe Silletti wrote:
> Have you tried to create a new 7zip archive and then add a file? If the archive \
> already exists it works properly.
> Raphael Kubo da Costa wrote:
> I did now: call `ark` without arguments -> Ctrl+N -> type something like "foo.7z" \
> and add/remove files. Everything still worked.
> Giuseppe Silletti wrote:
> Ok, please let's try a last thing following these steps:
> 1)Create a new archive from the New label
> 2)Write a name for the file like "foo", without adding the extension like you did \
> before 3)Choose the 7zip format from the list that appears
> 4)Now try to add some files, it shouldn't work.
Right, I could finally reproduce it after following your instructions, thank you.
Your patch actually breaks the standard case, as it always appends the extension to \
the archive name: if I create a new file called `foo.7z`, it will actually be called \
`foo.7z.7z`.
The underlying issue here is that some command-line programs (`zip`, `rar` and `7z`, \
but not `lha`) always append an extension to the archive name when it's being created \
if one is not specified. Since we cannot change this behavior, we have to either tell \
the user about this or try to handle it transparently. I'm tending to favor the \
former, and ask the user if it's OK to actually add an extension to the file being \
created (and cancel everything if the user does not want it), or just inform the user \
that the file name had to be changed.
- Raphael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122897/#review77609
-----------------------------------------------------------
On March 11, 2015, 12:17 a.m., Giuseppe Silletti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122897/
> -----------------------------------------------------------
>
> (Updated March 11, 2015, 12:17 a.m.)
>
>
> Review request for KDE Utils and Raphael Kubo da Costa.
>
>
> Repository: ark
>
>
> Description
> -------
>
> Ark doesn't access to a new 7z archive properly. I've made the \
> substituteListVariables function in cliinterface.cpp virtual, and then added it in \
> 7z cliplugin.cpp. In this file i've overridden substituteListVariables, and then \
> i've appended the .7z extension to the filename() function. So now ark can find the \
> right path of 7z archives.
>
> Diffs
> -----
>
> kerfuffle/cliinterface.h b4d79ed
> plugins/cli7zplugin/cliplugin.h 9f122e4
> plugins/cli7zplugin/cliplugin.cpp 500f121
>
> Diff: https://git.reviewboard.kde.org/r/122897/diff/
>
>
> Testing
> -------
>
> I've added some files in a new archive and it works.
>
>
> Thanks,
>
> Giuseppe Silletti
>
>
--===============1275250421188196285==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122897/">https://git.reviewboard.kde.org/r/122897/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 17th, 2015, 11:58 a.m. EET, <b>Raphael \
Kubo da Costa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Thanks a lot for the patch and sorry for being absent. \
Does this mean Ark is currently unable to add/remove files from 7z archives, or is it \
that the file list is not updated after that is done? Are you using the new p7zip \
(9.38.1)?</p></pre> </blockquote>
<p>On March 17th, 2015, 6:40 p.m. EET, <b>Giuseppe Silletti</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It is \
that the file list is not updated after adding a file. I'm using the last version of \
p7zip.</p></pre> </blockquote>
<p>On March 18th, 2015, 10 p.m. EET, <b>Raphael Kubo da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've \
just tried Ark here (latest <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">master</code>) with p7zip 9.38.1. I had an archive with a single file in \
it. I was able to add two new files and remove them, and the file list was updated \
correctly. Can you file a bug report and attach a file and some steps showing I could \
reproduce the issue you are having?</p></pre> </blockquote>
<p>On March 18th, 2015, 10:41 p.m. EET, <b>Giuseppe Silletti</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Have \
you tried to create a new 7zip archive and then add a file? If the archive already \
exists it works properly.</p></pre> </blockquote>
<p>On March 18th, 2015, 11:40 p.m. EET, <b>Raphael Kubo da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I did \
now: call <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">ark</code> without arguments -> Ctrl+N \
-> type something like "foo.7z" and add/remove files. Everything still \
worked.</p></pre> </blockquote>
<p>On March 19th, 2015, 4:23 p.m. EET, <b>Giuseppe Silletti</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok, \
please let's try a last thing following these steps: 1)Create a new archive from the \
New label 2)Write a name for the file like "foo", without adding the extension like \
you did before 3)Choose the 7zip format from the list that appears
4)Now try to add some files, it shouldn't work.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Right, I could finally reproduce it after following your instructions, \
thank you.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Your patch actually breaks the standard case, as it \
always appends the extension to the archive name: if I create a new file called <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">foo.7z</code>, it will actually be called <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">foo.7z.7z</code>.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The underlying issue \
here is that some command-line programs (<code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">zip</code>, \
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">rar</code> and <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">7z</code>, but not <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">lha</code>) \
always append an extension to the archive name when it's being created if one is not \
specified. Since we cannot change this behavior, we have to either tell the user \
about this or try to handle it transparently. I'm tending to favor the former, and \
ask the user if it's OK to actually add an extension to the file b eing created (and \
cancel everything if the user does not want it), or just inform the user that the \
file name had to be changed.</p></pre> <br />
<p>- Raphael</p>
<br />
<p>On March 11th, 2015, 12:17 a.m. EET, Giuseppe Silletti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Utils and Raphael Kubo da Costa.</div>
<div>By Giuseppe Silletti.</div>
<p style="color: grey;"><i>Updated March 11, 2015, 12:17 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ark doesn't access to a new 7z archive properly. I've \
made the substituteListVariables function in cliinterface.cpp virtual, and then added \
it in 7z cliplugin.cpp. In this file i've overridden substituteListVariables, and \
then i've appended the .7z extension to the filename() function. So now ark can find \
the right path of 7z archives.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I've added some files in a new archive and it \
works.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kerfuffle/cliinterface.h <span style="color: grey">(b4d79ed)</span></li>
<li>plugins/cli7zplugin/cliplugin.h <span style="color: grey">(9f122e4)</span></li>
<li>plugins/cli7zplugin/cliplugin.cpp <span style="color: \
grey">(500f121)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122897/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1275250421188196285==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic