[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-utils-devel
Subject: Re: Review Request 121468: Fix crash when right-clicking a Part entry
From: "Raphael Kubo da Costa" <rakuco () FreeBSD ! org>
Date: 2014-12-16 22:05:42
Message-ID: 20141216220542.31946.99181 () probe ! kde ! org
[Download RAW message or body]
--===============0380078237815520485==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121468/#review72143
-----------------------------------------------------------
Ship it!
Please change the logic to
```
if (!factory()) {
return;
}
// rest of the code
```
instead, as you then do not need to indent the successful case. Remember to commit to \
Applications/14.12 and then merge into master.
- Raphael Kubo da Costa
On Dec. 12, 2014, 5:41 p.m., Elvis Angelaccio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121468/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2014, 5:41 p.m.)
>
>
> Review request for KDE Utils and Raphael Kubo da Costa.
>
>
> Bugs: 341809
> http://bugs.kde.org/show_bug.cgi?id=341809
>
>
> Repository: ark
>
>
> Description
> -------
>
> My commit ed3ea7d introduced a bug that we didn't catch. When previewing an archive \
> inside another archive, `factory()` returns a null pointer and so there is a \
> segfault while attempting to show the context menu (after right-clicking an entry \
> of the previewed archive). The bug is trivally fixable by checking the validity of \
> the `factory()` pointer, but this way the context menu is not showed at all. I \
> think this should be fine, since we are talking about a read only preview of the \
> archive and thus the only enabled action within the context menu would be \
> `Preview`.
>
> Diffs
> -----
>
> part/part.cpp 09fe1cbfcc7f4345fe12932055dcb041f50abb7b
>
> Diff: https://git.reviewboard.kde.org/r/121468/diff/
>
>
> Testing
> -------
>
> Compile and test by previewing an archive inside another archive: now the crash is \
> gone and nothing happens after right-clicking one of its entry.
>
> Thanks,
>
> Elvis Angelaccio
>
>
--===============0380078237815520485==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121468/">https://git.reviewboard.kde.org/r/121468/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Please change the logic to</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" \
style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: \
#008000; font-weight: bold">if</span> (<span style="color: \
#666666">!</span>factory()) { <span style="color: #008000; font-weight: \
bold">return</span>; }
<span style="color: #408080; font-style: italic">// rest of the code</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">instead, as you then do not need to indent the \
successful case. Remember to commit to Applications/14.12 and then merge into \
master.</p></pre> <br />
<p>- Raphael Kubo da Costa</p>
<br />
<p>On December 12th, 2014, 5:41 p.m. EET, Elvis Angelaccio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Utils and Raphael Kubo da Costa.</div>
<div>By Elvis Angelaccio.</div>
<p style="color: grey;"><i>Updated Dec. 12, 2014, 5:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=341809">341809</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">My commit ed3ea7d introduced a bug that we didn't \
catch. When previewing an archive inside another archive, <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">factory()</code> returns a null pointer and so there is a \
segfault while attempting to show the context menu (after right-clicking an entry of \
the previewed archive). The bug is trivally fixable by checking the validity of the \
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">factory()</code> pointer, but this way the \
context menu is not showed at all. I think this should be fine, since we are talking \
about a read only preview of the archive and thus the only enabled action within the \
context menu would be <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">Preview</code>.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compile and test by previewing an archive inside \
another archive: now the crash is gone and nothing happens after right-clicking one \
of its entry.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/part.cpp <span style="color: \
grey">(09fe1cbfcc7f4345fe12932055dcb041f50abb7b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121468/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0380078237815520485==--
_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic