'Re: Review Request 119893: Ensure destination is writable before extraction'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-utils-devel
Subject:    Re: Review Request 119893: Ensure destination is writable before extraction
From:       "Raphael Kubo da Costa" <rakuco () FreeBSD ! org>
Date:       2014-12-11 23:13:23
Message-ID: 20141211231323.4026.62199 () probe ! kde ! org
[Download RAW message or body]

--===============1897029441806790999==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119893/#review71838
-----------------------------------------------------------

Quick comments while on holiday: please sort your includes, and I would expect this \
kind of check to be in a place that would work for both drag'n'drop and regular \
extractions.

- Raphael Kubo da Costa

On Dec. 10, 2014, 9:53 p.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119893/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 9:53 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> 1. Open dolphin, drag and drop an archive file onto a read-only directory in the  \
> places panel 2. All the files get extracted to the home directory
> 
> 
> Diffs
> -----
> 
> app/extractHereDndPlugin.cpp 685a6b7 
> 
> Diff: https://git.reviewboard.kde.org/r/119893/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
> 

--===============1897029441806790999==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119893/">https://git.reviewboard.kde.org/r/119893/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Quick \
comments while on holiday: please sort your includes, and I would expect this kind of \
check to be in a place that would work for both drag'n'drop and regular \
extractions.</p></pre>  <br />

<p>- Raphael Kubo da Costa</p>

<br />
<p>On December 10th, 2014, 9:53 p.m. EET, Arjun AK wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Utils and Raphael Kubo da Costa.</div>
<div>By Arjun AK.</div>

<p style="color: grey;"><i>Updated Dec. 10, 2014, 9:53 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
2em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Open dolphin, drag and \
drop an archive file onto a read-only directory in the  places panel</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">All the files get extracted to the home directory</li> </ol></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>app/extractHereDndPlugin.cpp <span style="color: grey">(685a6b7)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119893/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1897029441806790999==--

_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel

[prev in list] [next in list] [prev in thread] [next in thread] 