'Re: Review Request 114658: Fixes the data loss caused when user closes kwalletmanager with unsaved c'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-utils-devel
Subject:    Re: Review Request 114658: Fixes the data loss caused when user closes kwalletmanager with unsaved c
From:       "Christoph Feck" <christoph () maxiom ! de>
Date:       2014-02-09 15:34:28
Message-ID: 20140209153428.4159.4269 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Dec. 25, 2013, 10:15 p.m., Valentin Rusu wrote:
> > Ship It!

What is the status of this patch? Arjun probably has no commit rights.

- Christoph

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114658/#review46154
-----------------------------------------------------------

On Dec. 25, 2013, 1:01 p.m., Arjun Ak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114658/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2013, 1:01 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Bugs: 329165
>     http://bugs.kde.org/show_bug.cgi?id=329165
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> Patch to fix Bug 329165(Closing the app leads to loss of unsaved data)
> 
> 
> Diffs
> -----
> 
>   src/manager/kwalleteditor.h f3d08f3 
>   src/manager/kwalleteditor.cpp 6f07b7d 
>   src/manager/kwalletmanager.h 7489077 
>   src/manager/kwalletmanager.cpp 355fda7 
>   src/manager/kwalletmanagerwidget.h df1e4fa 
>   src/manager/kwalletmanagerwidget.cpp c855c91 
>   src/manager/kwalletmanagerwidgetitem.h ad2451e 
>   src/manager/kwalletmanagerwidgetitem.cpp 79bb476 
>   src/manager/walletcontrolwidget.h fb94999 
>   src/manager/walletcontrolwidget.cpp 948cc60 
> 
> Diff: https://git.reviewboard.kde.org/r/114658/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114658/">https://git.reviewboard.kde.org/r/114658/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On December 25th, 2013, 10:15 p.m. UTC, \
<b>Valentin Rusu</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: \
2px solid #d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; \
white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; \
word-wrap: break-word;">Ship It!</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What is the status of \
this patch? Arjun probably has no commit rights.</pre> <br />

<p>- Christoph</p>

<br />
<p>On December 25th, 2013, 1:01 p.m. UTC, Arjun Ak wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Utils.</div>
<div>By Arjun Ak.</div>

<p style="color: grey;"><i>Updated Dec. 25, 2013, 1:01 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=329165">329165</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwallet
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch to fix Bug 329165(Closing the app leads to loss of unsaved \
data)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/manager/kwalleteditor.h <span style="color: grey">(f3d08f3)</span></li>

 <li>src/manager/kwalleteditor.cpp <span style="color: grey">(6f07b7d)</span></li>

 <li>src/manager/kwalletmanager.h <span style="color: grey">(7489077)</span></li>

 <li>src/manager/kwalletmanager.cpp <span style="color: grey">(355fda7)</span></li>

 <li>src/manager/kwalletmanagerwidget.h <span style="color: \
grey">(df1e4fa)</span></li>

 <li>src/manager/kwalletmanagerwidget.cpp <span style="color: \
grey">(c855c91)</span></li>

 <li>src/manager/kwalletmanagerwidgetitem.h <span style="color: \
grey">(ad2451e)</span></li>

 <li>src/manager/kwalletmanagerwidgetitem.cpp <span style="color: \
grey">(79bb476)</span></li>

 <li>src/manager/walletcontrolwidget.h <span style="color: \
grey">(fb94999)</span></li>

 <li>src/manager/walletcontrolwidget.cpp <span style="color: \
grey">(948cc60)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114658/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel

[prev in list] [next in list] [prev in thread] [next in thread] 