[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-utils-devel
Subject: Re: Review Request 112068: KCharSelect: Show LaTeX commands for Unicode characters
From: "Daniel Laidig" <laidig () kde ! org>
Date: 2013-09-13 14:29:36
Message-ID: 20130913142936.6694.94151 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112068/#review39970
-----------------------------------------------------------
Sorry that i reply that late. :/
I would be very happy to see that feature in KCharSelect.
Christoph was right, my first thought was that this should be in the data file and \
not in the C++ code. However, after thinking a while about it, I'm not so sure any \
more. The problem is not that the other data comes from unicode.org -- there is no \
reason to not add other sources. But I assume that this will make the syncing with \
KBibTeX more difficult (because it means porting it to Python). Additionally, there \
are not too many LaTeX characters and putting it in the data file will cause overhead \
for every Unicode character, so it might not be worth it.
So from my side, I think it looks good and keeping it as C++ seems to be a good \
option. I don't have a development setup right now and I don't want to say "Ship it" \
without being able to compile and test, but from me there are no objections. :)
- Daniel Laidig
On Aug. 16, 2013, 7:16 p.m., Thomas Fischer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112068/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2013, 7:16 p.m.)
>
>
> Review request for kdelibs, KDE Utils and Daniel Laidig.
>
>
> Description
> -------
>
> Attached patch tries to determine the LaTeX command sequence for a given Unicode \
> character. Right now, the most common latin-based characters and selected symbols \
> are covered. The translation table is based on the source code used in KBibTeX \
> (BibTeX editor) and corrections/updates can be easily shared between both projects. \
>
> Diffs
> -----
>
> kdeui/widgets/kcharselect.h de9e184
> kdeui/widgets/kcharselect.cpp e00d001
> kdeui/widgets/kcharselectdata.cpp 41eab5b
> kdeui/widgets/kcharselectdata_p.h c6f7a3a
>
> Diff: http://git.reviewboard.kde.org/r/112068/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Fischer
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112068/">http://git.reviewboard.kde.org/r/112068/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry that i reply that \
late. :/
I would be very happy to see that feature in KCharSelect.
Christoph was right, my first thought was that this should be in the data file and \
not in the C++ code. However, after thinking a while about it, I'm not so sure \
any more. The problem is not that the other data comes from unicode.org -- there is \
no reason to not add other sources. But I assume that this will make the syncing with \
KBibTeX more difficult (because it means porting it to Python). Additionally, there \
are not too many LaTeX characters and putting it in the data file will cause overhead \
for every Unicode character, so it might not be worth it.
So from my side, I think it looks good and keeping it as C++ seems to be a good \
option. I don't have a development setup right now and I don't want to say \
"Ship it" without being able to compile and test, but from me there are no \
objections. :)</pre> <br />
<p>- Daniel</p>
<br />
<p>On August 16th, 2013, 7:16 p.m. UTC, Thomas Fischer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, KDE Utils and Daniel Laidig.</div>
<div>By Thomas Fischer.</div>
<p style="color: grey;"><i>Updated Aug. 16, 2013, 7:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Attached patch tries to determine the LaTeX command sequence for a given \
Unicode character. Right now, the most common latin-based characters and selected \
symbols are covered. The translation table is based on the source code used in \
KBibTeX (BibTeX editor) and corrections/updates can be easily shared between both \
projects.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/widgets/kcharselect.h <span style="color: grey">(de9e184)</span></li>
<li>kdeui/widgets/kcharselect.cpp <span style="color: grey">(e00d001)</span></li>
<li>kdeui/widgets/kcharselectdata.cpp <span style="color: \
grey">(41eab5b)</span></li>
<li>kdeui/widgets/kcharselectdata_p.h <span style="color: \
grey">(c6f7a3a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112068/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic