'Re: Review Request 109847: Sort email addresses in main list by TLD first, then domain, and only las'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-utils-devel
Subject:    Re: Review Request 109847: Sort email addresses in main list by TLD first, then domain, and only las
From:       "Thomas Fischer" <fischer () unix-ag ! uni-kl ! de>
Date:       2013-06-24 9:11:58
Message-ID: 20130624091158.12555.18921 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109847/
-----------------------------------------------------------

(Updated June 24, 2013, 9:11 a.m.)

Review request for KDE Utils.

Changes
-------

> I wonder what happens to emails like foo.bar@example.com with TLDfirst, the
> regex will split them into foo, bar, example, com AFAICT, which would screw
> up sorting, no?
I rewrote this case, should work better now, too.
The patch contains some minor rewrites for the other cases as well plus some unifications in the white \
spaces.

> For an unknown reason the items added in the ui file are ignored, they only 
> appear when added again in C++.
No idea either.

> When the setting is changed and Accept or OK is clicked keysmanager will not
> refresh it's display. You should probably call something like invalidateFilter
> on the filter model used for the main view.
Observed as well. How do I trigger such a refresh/invalidation? The settings/options class do no see the \
model (or the view) directly as far as I can see...

Description
-------

Sort email addresses in main list by TLD first, then domain, and only last by account name.
(1) email address is split along @ and .
(2a) list is reversed
(2b) list elements are joined, two elements separated by .

This addresses bug 278376.
    http://bugs.kde.org/show_bug.cgi?id=278376

Diffs (updated)
-----

  model/keylistproxymodel.cpp cecb836 

Diff: http://git.reviewboard.kde.org/r/109847/diff/

Testing
-------

Thanks,

Thomas Fischer

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109847/">http://git.reviewboard.kde.org/r/109847/</a>
     </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KDE Utils.</div>
<div>By Thomas Fischer.</div>

<p style="color: grey;"><i>Updated June 24, 2013, 9:11 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">&gt; I wonder what happens to emails like \
foo.bar@example.com with TLDfirst, the &gt; regex will split them into foo, bar, example, com AFAICT, \
which would screw &gt; up sorting, no?
I rewrote this case, should work better now, too.
The patch contains some minor rewrites for the other cases as well plus some unifications in the white \
spaces.

&gt; For an unknown reason the items added in the ui file are ignored, they only 
&gt; appear when added again in C++.
No idea either.

&gt; When the setting is changed and Accept or OK is clicked keysmanager will not
&gt; refresh it&#39;s display. You should probably call something like invalidateFilter
&gt; on the filter model used for the main view.
Observed as well. How do I trigger such a refresh/invalidation? The settings/options class do no see the \
model (or the view) directly as far as I can see...</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sort email addresses in main list by TLD \
first, then domain, and only last by account name. (1) email address is split along @ and .
(2a) list is reversed
(2b) list elements are joined, two elements separated by .</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=278376">278376</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>model/keylistproxymodel.cpp <span style="color: grey">(cecb836)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109847/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel

[prev in list] [next in list] [prev in thread] [next in thread] 