[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-utils-devel
Subject: Re: Review Request 109847: Sort email addresses in main list by TLD first, then domain, and only las
From: "Rolf Eike Beer" <kde () opensource ! sf-tec ! de>
Date: 2013-04-28 20:08:55
Message-ID: 20130428200855.14550.29724 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109847/#review31710
-----------------------------------------------------------
Looks like you have forgotten to add at least one file to the diff:
kgpg/model/keylistproxymodel.cpp: In member function ‘QString \
KeyListProxyModelPrivate::reorderEmailComponents(const QString&) const': \
kgpg/model/keylistproxymodel.cpp:68:10: error: ‘emailSorting' is not a member of \
‘KGpgSettings'
Also from a first look I would say you should simplify the email regexes. We don't \
really care about the validity of the addresses in the keys here at all. So simply \
split them at @ and . as said in the description, and ignore whatever other \
characters are in between that. So if the email address is foo@example or \
bar@example.invalid that's fine for sorting here.
- Rolf Eike Beer
On April 7, 2013, 3:46 p.m., Thomas Fischer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109847/
> -----------------------------------------------------------
>
> (Updated April 7, 2013, 3:46 p.m.)
>
>
> Review request for KDE Utils.
>
>
> Description
> -------
>
> Sort email addresses in main list by TLD first, then domain, and only last by \
> account name. (1) email address is split along @ and .
> (2a) list is reversed
> (2b) list elements are joined, two elements separated by .
>
>
> This addresses bug 278376.
> http://bugs.kde.org/show_bug.cgi?id=278376
>
>
> Diffs
> -----
>
> conf_ui2.ui f970cd2
> kgpgoptions.h e609aa8
> kgpgoptions.cpp 12adc56
> model/keylistproxymodel.cpp e91cb08
>
> Diff: http://git.reviewboard.kde.org/r/109847/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Fischer
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109847/">http://git.reviewboard.kde.org/r/109847/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks like you have \
forgotten to add at least one file to the diff:
kgpg/model/keylistproxymodel.cpp: In member function ‘QString \
KeyListProxyModelPrivate::reorderEmailComponents(const QString&) const': \
kgpg/model/keylistproxymodel.cpp:68:10: error: ‘emailSorting' is not a member of \
‘KGpgSettings'
Also from a first look I would say you should simplify the email regexes. We \
don't really care about the validity of the addresses in the keys here at all. So \
simply split them at @ and . as said in the description, and ignore whatever other \
characters are in between that. So if the email address is foo@example or \
bar@example.invalid that's fine for sorting here.</pre> <br />
<p>- Rolf Eike</p>
<br />
<p>On April 7th, 2013, 3:46 p.m. UTC, Thomas Fischer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Utils.</div>
<div>By Thomas Fischer.</div>
<p style="color: grey;"><i>Updated April 7, 2013, 3:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Sort email addresses in main list by TLD first, then domain, and only \
last by account name. (1) email address is split along @ and .
(2a) list is reversed
(2b) list elements are joined, two elements separated by .</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=278376">278376</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>conf_ui2.ui <span style="color: grey">(f970cd2)</span></li>
<li>kgpgoptions.h <span style="color: grey">(e609aa8)</span></li>
<li>kgpgoptions.cpp <span style="color: grey">(12adc56)</span></li>
<li>model/keylistproxymodel.cpp <span style="color: grey">(e91cb08)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109847/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic