'Review Request: avoid a crash when the opened archive is moved'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-utils-devel
Subject:    Review Request: avoid a crash when the opened archive is moved
From:       "Jaime Torres Amate" <jtamate () gmail ! com>
Date:       2012-10-14 10:07:45
Message-ID: 20121014100745.4911.66814 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106842/
-----------------------------------------------------------

Review request for KDE Utils.

Description
-------

all emit error in libarchivehandler.cpp use only one argument, therefore, t=
he signal is not the same as the one declared.
Fortunately, those hard to avoid mistakes will be gone with Qt5. =

Diffs
-----

  kerfuffle/jobs.h d704dfc =

Diff: http://git.reviewboard.kde.org/r/106842/diff/

Testing
-------

open with ark a .tar.gz file, move the opened .tar.gz file. try to preview =
any file of the opened .tar.gz.
without the patch, crash.
with the patch, the expected error message.

Thanks,

Jaime Torres Amate

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106842/">http://git.reviewboard.kde.org/r/106842/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KDE Utils.</div>
<div>By Jaime Torres Amate.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">all emit error in \
libarchivehandler.cpp use only one argument, therefore, the signal is not the same as the one \
declared. Fortunately, those hard to avoid mistakes will be gone with Qt5. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">open with ark a \
.tar.gz file, move the opened .tar.gz file. try to preview any file of the opened .tar.gz. \
without the patch, crash. with the patch, the expected error message.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kerfuffle/jobs.h <span style="color: grey">(d704dfc)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106842/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel

[prev in list] [next in list] [prev in thread] [next in thread] 