'Review Request: enhance performance at updating KWallet Editor Tree'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-utils-devel
Subject:    Review Request: enhance performance at updating KWallet Editor Tree
From:       "Martin Koller" <kollix () aon ! at>
Date:       2012-07-20 21:25:37
Message-ID: 20120720212537.29807.86817 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105633/
-----------------------------------------------------------

Review request for KDE Utils, Michael Leupold and Raphael Kubo da Costa.

Description
-------

I have > 340 entries in "Form Data" in the wallet. When opening the wallet editor, it takes about 9 \
Seconds until the tree is displayed! I investigated the problem and found out that this is due to 2 \
reasons: 1.) The list of entries is checked against existing entries in the tree, which is done by linear \
search in the given entries list and in the tree  which results in a quadratic complexity.
2.) unneeded duplicate dbus calls

I solved the first by using QSet for fast lookup and I reduced the second problem by avoiding a \
duplicate, unneeded query over dbus

This addresses bugs 279161 and 284671.
    http://bugs.kde.org/show_bug.cgi?id=279161
    http://bugs.kde.org/show_bug.cgi?id=284671

Diffs
-----

  allyourbase.h d3452cd 
  allyourbase.cpp f57eb68 
  kwalleteditor.cpp 777ce8d 

Diff: http://git.reviewboard.kde.org/r/105633/diff/

Testing
-------

Thanks,

Martin Koller

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105633/">http://git.reviewboard.kde.org/r/105633/</a>
     </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KDE Utils, Michael Leupold and Raphael Kubo da Costa.</div>
<div>By Martin Koller.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have &gt; 340 entries in &quot;Form \
Data&quot; in the wallet. When opening the wallet editor, it takes about 9 Seconds until the tree is \
displayed! I investigated the problem and found out that this is due to 2 reasons:
1.) The list of entries is checked against existing entries in the tree, which is done by linear search \
in the given entries list and in the tree  which results in a quadratic complexity.
2.) unneeded duplicate dbus calls

I solved the first by using QSet for fast lookup and I reduced the second problem by avoiding a \
duplicate, unneeded query over dbus</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=279161">279161</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=284671">284671</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>allyourbase.h <span style="color: grey">(d3452cd)</span></li>

 <li>allyourbase.cpp <span style="color: grey">(f57eb68)</span></li>

 <li>kwalleteditor.cpp <span style="color: grey">(777ce8d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105633/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel

[prev in list] [next in list] [prev in thread] [next in thread] 