'Review Request: Restore the ability to use Ark as an embedded KPart'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-utils-devel
Subject:    Review Request: Restore the ability to use Ark as an embedded KPart
From:       "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date:       2010-09-22 14:13:59
Message-ID: 20100922141359.15688.25805 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5405/
-----------------------------------------------------------

Review request for kdeutils.

Summary
-------

In KDE3 it was possible to use Ark as am embedded KPart, e.g. to browse the=
 contents of a remote archive inside Konqueror.  Now in KDE4 this is not po=
ssible, ark_part.desktop is installed but contains no MimeTypes list.

This change restores the MIME type list (copied verbatim from the Ark appli=
cation's desktop file) and also corrects the incorrect icon name.

Diffs
-----

  /trunk/KDE/kdeutils/ark/part/ark_part.desktop 1178175 =

Diff: http://svn.reviewboard.kde.org/r/5405/diff

Testing
-------

Built and installed Ark with these changes, it is now possible to preview t=
he contents of an archive within Konqueror.

Thanks,

Jonathan

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5405/">http://svn.reviewboard.kde.org/r/5405/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdeutils.</div>
<div>By Jonathan Marten.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In KDE3 it was possible to use Ark as am embedded KPart, e.g. to browse \
the contents of a remote archive inside Konqueror.  Now in KDE4 this is not possible, \
ark_part.desktop is installed but contains no MimeTypes list.

This change restores the MIME type list (copied verbatim from the Ark \
application&#39;s desktop file) and also corrects the incorrect icon name. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built and installed Ark with these changes, it is now possible to \
preview the contents of an archive within Konqueror.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdeutils/ark/part/ark_part.desktop <span style="color: \
grey">(1178175)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5405/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel

[prev in list] [next in list] [prev in thread] [next in thread] 