[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-usability
Subject: Re: Review Request 130208: Add menu with "Copy to Clipboard" to the About System module
From: Gregor Mi <codestruct () posteo ! org>
Date: 2017-08-03 9:41:04
Message-ID: 20170803094104.5572.5155 () mimi ! kde ! org
[Download RAW message or body]
--===============1703346045297862381==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On July 31, 2017, 3:59 a.m., Anthony Fieroni wrote:
> > Modules/about-distro/src/Module.cpp, line 198
> > <https://git.reviewboard.kde.org/r/130208/diff/1/?file=498299#file498299line198>
> >
> > Plasma now depends on minimum 5.30, you can remove this check. Plasma team now \
> > use Phabricator and i don't know if David and Marco still read reviewboard.
implemented in https://phabricator.kde.org/D7087
- Gregor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130208/#review103510
-----------------------------------------------------------
On July 31, 2017, 7:44 a.m., Gregor Mi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130208/
> -----------------------------------------------------------
>
> (Updated July 31, 2017, 7:44 a.m.)
>
>
> Review request for Plasma and KDE Usability.
>
>
> Repository: kinfocenter
>
>
> Description
> -------
>
> Add a new menu with a "Copy to Clipboard" action to the About System module. See \
> screenshot. The action can be used to conveniently copy information when reporting \
> a bug etc.
> Example of how the copied text looks like:
>
> KDE Frameworks Version: 5.37.0
> Qt Version: 5.9.0
> Distro: openSUSE Tumbleweed 20170407
> Kernel: 4.10.8-1-default
> OS Type: 64 bit
> Processors: 4 × Intel ® Coreâ„¢ i3 CPU M 370 @ 2.40GHz
> Memory: 7,7 GiB of RAM
>
>
> Diffs
> -----
>
> Modules/about-distro/src/Module.h 55337b0e057fda97019291ba1dda1a5c330bb05a
> Modules/about-distro/src/Module.cpp 1852376f96f1f6f4b1cbfdea446270000f84f401
> Modules/about-distro/src/Module.ui 7aff8c4b9162ee04240d0b77f3b1ec9757420322
>
> Diff: https://git.reviewboard.kde.org/r/130208/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> About System with the new menu
> https://git.reviewboard.kde.org/media/uploaded/files/2017/07/30/13bd0d7a-7a6a-4b48-90ba-4a6dffccd2ac__about-system-1.png
> About system with the new menu opened
> https://git.reviewboard.kde.org/media/uploaded/files/2017/07/30/9a79cbb6-0c50-4d4d-b24c-48e534aa9086__about-system-menu-open.png
>
>
> Thanks,
>
> Gregor Mi
>
>
--===============1703346045297862381==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130208/">https://git.reviewboard.kde.org/r/130208/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 31st, 2017, 3:59 a.m. UTC, <b>Anthony \
Fieroni</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/130208/diff/1/?file=498299#file498299line198" \
style="color: black; font-weight: bold; text-decoration: \
underline;">Modules/about-distro/src/Module.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">185</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#if \
KCOREADDONS_VERSION >= QT_VERSION_CHECK(5,20,0)</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">198</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#if KCOREADDONS_VERSION >= QT_VERSION_CHECK(5,20,0)</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Plasma now depends on minimum 5.30, you can remove this check. Plasma team \
now use Phabricator and i don't know if David and Marco still read \
reviewboard.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">implemented in https://phabricator.kde.org/D7087</p></pre> <br />
<p>- Gregor</p>
<br />
<p>On July 31st, 2017, 7:44 a.m. UTC, Gregor Mi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated July 31, 2017, 7:44 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kinfocenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Add a new menu with a "Copy to Clipboard" action to \
the About System module. See screenshot. The action can be used to conveniently copy \
information when reporting a bug etc.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Example of how the \
copied text looks like:</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">KDE Frameworks Version: 5.37.0 Qt \
Version: 5.9.0
Distro: openSUSE Tumbleweed 20170407
Kernel: 4.10.8-1-default
OS Type: 64 bit
Processors: 4 × Intel ® Coreâ„¢ i3 CPU M 370 @ 2.40GHz
Memory: 7,7 GiB of RAM</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>Modules/about-distro/src/Module.h <span style="color: \
grey">(55337b0e057fda97019291ba1dda1a5c330bb05a)</span></li>
<li>Modules/about-distro/src/Module.cpp <span style="color: \
grey">(1852376f96f1f6f4b1cbfdea446270000f84f401)</span></li>
<li>Modules/about-distro/src/Module.ui <span style="color: \
grey">(7aff8c4b9162ee04240d0b77f3b1ec9757420322)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130208/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2017/07/30/13bd0d7a-7a6a-4b48-90ba-4a6dffccd2ac__about-system-1.png">About \
System with the new menu</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2017/07/30/9a79cbb6-0c50-4d4d-b24c-48e534aa9086__about-system-menu-open.png">About \
system with the new menu opened</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1703346045297862381==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic