[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request 128715: Bug 205157 - two clicks on file to rename
From: Kåre Särs <kare.sars () iki ! fi>
Date: 2017-03-14 14:20:48
Message-ID: 20170314142048.8720.66302 () mimi ! kde ! org
[Download RAW message or body]
--===============5911356698391860868==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Sept. 4, 2016, 12:18 p.m., Emmanuel Pescosta wrote:
> > Thanks for the patch!
> >
> > I don't think that we should add another option for this, because it makes the \
> > settings dialog more complex, it increases the number of possible configs to \
> > test, it only makes sense when single click + inline renaming is enabled.
> >
> > What if we always enable it when the options 'single click' and 'inline renaming' \
> > are enabled?
> > Please add the usability group to this discussion :)
>
> Thomas Pfeiffer wrote:
> Usability team agrees :)
> No additional option, activate it automatically when single-click and \
> inline-renaming are activated
> funky bomber wrote:
> Hello,
>
> This feature doesn't seem to have been implemented yet (as of Applications 16.12), \
> so I thought I might give my 2c as well.
>
> I have a hard time understanding how this feature is supposed to work if (as you \
> say) it should require "single-click" to be activated. Why is that so? In my \
> understanding, an active "Single-click" means that when the user clicks once on a \
> file, this file opens or executes immediately. This is not what we want.
> The "two clicks to rename" functionality makes sense only when the "Double-click" \
> option is activated: 1) One click on the file (or folder) to highlight it.
> 2) (Brief pause) <-- (The user can already set the "Double click interval" to \
> whichever value suits them so that we don't trigger the double-click by accident.) \
> 3) Second click on the file (or folder) to make the text editable.
> Pretty much the same as in this video:
> https://www.youtube.com/watch?v=52BSGNY9DQ0
>
>
> In regards to the complexity thing, I understand that each option that is added \
> creates complexity. However it is the best way to isolate this behavior from users \
> who may not want it. No size fits all. And I think that this functionality is kind \
> of a big deal. It deserves it's own setting. If not for anything else, then just \
> so that people can find it and disable it easily if they don't want it.
> Hope to see this properly implemented in Applications 17.04!
>
> Cheers!
>
> Anthony Fieroni wrote:
> It should implement pretty simple, when user click over a selected item (it can be \
> select more than one) rename is activated. Simple and useful, but yes only in \
> double click branch
Having this in the "double-click" mode breaks the "Items are only selected with a \
single-click". It would have to be some kind of slower double click to not introduce \
a bunch of unwanted file renames. I find the in-line-rename found in Windows totally \
annoying. Selecting a file that happened to be selected already starts rename. What \
is wrong with explicitly pressing F2 or right-clicking the file?
And I have a bit hard time to understand how it could work in single-click mode when \
the file should be opened not renamed on single-click.
- Kåre
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128715/#review98869
-----------------------------------------------------------
On Sept. 5, 2016, 10:29 p.m., Andreas Krutzler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128715/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2016, 10:29 p.m.)
>
>
> Review request for Dolphin and KDE Usability.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> Bug 205157 - two clicks on file to rename
>
>
> Diffs
> -----
>
> src/kitemviews/kitemlistcontroller.h b8a93ed
> src/kitemviews/kitemlistcontroller.cpp 1c86ff0
> src/kitemviews/kitemlistview.h 9adf9f8
> src/kitemviews/kitemlistview.cpp df65399
> src/views/dolphinview.h 0b0d819
> src/views/dolphinview.cpp 4105628
>
> Diff: https://git.reviewboard.kde.org/r/128715/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andreas Krutzler
>
>
--===============5911356698391860868==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128715/">https://git.reviewboard.kde.org/r/128715/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 4th, 2016, 12:18 p.m. UTC, \
<b>Emmanuel Pescosta</b> wrote:</p> <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">Thanks for the patch!
I don't think that we should add another option for this, because it makes the \
settings dialog more complex, it increases the number of possible configs to test, it \
only makes sense when single click + inline renaming is enabled.
What if we always enable it when the options 'single click' and 'inline \
renaming' are enabled?
Please add the usability group to this discussion :)</pre>
</blockquote>
<p>On September 5th, 2016, 10:29 a.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Usability team agrees :) No additional option, activate it automatically \
when single-click and inline-renaming are activated</p></pre> </blockquote>
<p>On March 14th, 2017, 12:18 p.m. UTC, <b>funky bomber</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Hello,</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This feature doesn't seem to have been \
implemented yet (as of Applications 16.12), so I thought I might give my 2c as well. \
</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I have a hard time understanding how this feature is \
supposed to work if (as you say) it should require "single-click" to be activated. \
Why is that so? In my understanding, an active "Single-click" means that when the \
user clicks once on a file, this file opens or executes immediately. This is not what \
we want.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The "two clicks to rename" functionality makes sense \
only when the "Double-click" option is activated: 1) One click on the file (or \
folder) to highlight it. 2) (Brief pause) <-- (The user can already set the \
"Double click interval" to whichever value suits them so that we don't trigger the \
double-click by accident.) 3) Second click on the file (or folder) to make the text \
editable.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Pretty much the same as in this video: \
https://www.youtube.com/watch?v=52BSGNY9DQ0</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">In regards to the \
complexity thing, I understand that each option that is added creates complexity. \
However it is the best way to isolate this behavior from users who may not want it. \
No size fits all. And I think that this functionality is kind of a big deal. It \
deserves it's own setting. If not for anything else, then just so that people can \
find it and disable it easily if they don't want it.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hope \
to see this properly implemented in Applications 17.04!</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Cheers!</p></pre> </blockquote>
<p>On March 14th, 2017, 12:33 p.m. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It \
should implement pretty simple, when user click over a selected item (it can be \
select more than one) rename is activated. Simple and useful, but yes only in double \
click branch</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Having this in the \
"double-click" mode breaks the "Items are only selected with a \
single-click". It would have to be some kind of slower double click to not \
introduce a bunch of unwanted file renames. I find the in-line-rename found in \
Windows totally annoying. Selecting a file that happened to be selected already \
starts rename. What is wrong with explicitly pressing F2 or right-clicking the file?
And I have a bit hard time to understand how it could work in single-click mode when \
the file should be opened not renamed on single-click.</pre> <br />
<p>- Kåre</p>
<br />
<p>On September 5th, 2016, 10:29 p.m. UTC, Andreas Krutzler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin and KDE Usability.</div>
<div>By Andreas Krutzler.</div>
<p style="color: grey;"><i>Updated Sept. 5, 2016, 10:29 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Bug 205157 - two clicks on file to rename</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kitemviews/kitemlistcontroller.h <span style="color: \
grey">(b8a93ed)</span></li>
<li>src/kitemviews/kitemlistcontroller.cpp <span style="color: \
grey">(1c86ff0)</span></li>
<li>src/kitemviews/kitemlistview.h <span style="color: grey">(9adf9f8)</span></li>
<li>src/kitemviews/kitemlistview.cpp <span style="color: grey">(df65399)</span></li>
<li>src/views/dolphinview.h <span style="color: grey">(0b0d819)</span></li>
<li>src/views/dolphinview.cpp <span style="color: grey">(4105628)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128715/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5911356698391860868==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic