[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-usability
Subject: Re: Review Request 129607: Display Application version in About dialog header
From: Thomas Pfeiffer <thomas.pfeiffer () kde ! org>
Date: 2016-12-05 23:10:10
Message-ID: 20161205231010.13487.26114 () mimi ! kde ! org
[Download RAW message or body]
--===============6213644978349396245==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Dec. 3, 2016, 4:48 p.m., Martin Klapetek wrote:
> > How about "Using" for the title of the tab and then removing the \
> > "Using" label from inside the tab?
> > Also, +1 to putting the version front.
Hm, "Using" sounds a bit weird without context, but "Libraries" or maybe \
"Libraries used" makes sense to me. The only thing that would not really \
fit from a purely technical perspective is the windowing system used \
(though that does not fit in "Version" either because it does not say \
anything about its version), but I don't think that is a problem.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129607/#review101247
-----------------------------------------------------------
On Dec. 3, 2016, 1:39 p.m., Jean-Baptiste Mardelle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129607/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2016, 1:39 p.m.)
>
>
> Review request for KDE Frameworks, KDE Usability and Sebastian Kügler.
>
>
> Repository: kxmlgui
>
>
> Description
> -------
>
> Last year, a change in kaboutapplicationdialog (review 124133) moved the \
> application version in a separate tab. However for applications, it is \
> really annoying (several Kdenlive users complained and I fully agree) to \
> not have this information clearly displayed as soon as the About dialog \
> is displayed. I understand the interest of having a separate version tab \
> displaying the various underlying libraries used, but I propose to \
> display again the application version in the About dialog header (see \
> screenshot).
>
> Diffs
> -----
>
> src/kaboutapplicationdialog.cpp 156410e
>
> Diff: https://git.reviewboard.kde.org/r/129607/diff/
>
>
> Testing
> -------
>
> Reverts a recent change, tested and works.
>
>
> File Attachments
> ----------------
>
> About dialog with version
> https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/c02f4767-2a74-4c25-8599-de410678867e__about.png
> Updated patch
> https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/ee13cb47-2162-4be7-8255-3dce7f470c2b__about2.png
>
>
> Thanks,
>
> Jean-Baptiste Mardelle
>
>
--===============6213644978349396245==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129607/">https://git.reviewboard.kde.org/r/129607/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <p style="margin-top: 0;">On December 3rd, 2016, \
4:48 p.m. UTC, <b>Martin Klapetek</b> wrote:</p> <blockquote \
style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">How about "Using" for the \
title of the tab and then removing the "Using" label from inside the \
tab?</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Also, +1 to putting the \
version front.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hm, "Using" sounds a bit weird without \
context, but "Libraries" or maybe "Libraries used" makes sense to me. The \
only thing that would not really fit from a purely technical perspective is \
the windowing system used (though that does not fit in "Version" either \
because it does not say anything about its version), but I don't think that \
is a problem.</p></pre> <br />
<p>- Thomas</p>
<br />
<p>On December 3rd, 2016, 1:39 p.m. UTC, Jean-Baptiste Mardelle wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, KDE Usability and Sebastian \
Kügler.</div> <div>By Jean-Baptiste Mardelle.</div>
<p style="color: grey;"><i>Updated Dec. 3, 2016, 1:39 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kxmlgui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Last year, a change in \
kaboutapplicationdialog (review 124133) moved the application version in a \
separate tab. However for applications, it is really annoying (several \
Kdenlive users complained and I fully agree) to not have this information \
clearly displayed as soon as the About dialog is displayed. I understand \
the interest of having a separate version tab displaying the various \
underlying libraries used, but I propose to display again the application \
version in the About dialog header (see screenshot).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Reverts a recent change, \
tested and works.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/kaboutapplicationdialog.cpp <span style="color: \
grey">(156410e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129607/diff/" \
style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File \
Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/c02f4767-2a74-4c25-8599-de410678867e__about.png">About \
dialog with version</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/ee13cb47-2162-4be7-8255-3dce7f470c2b__about2.png">Updated \
patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6213644978349396245==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic