[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-usability
Subject: Re: Review Request 129601: Left mouse double click fires a "go up"
From: Don Nguyen <don78colorado () gmail ! com>
Date: 2016-12-04 6:31:13
Message-ID: 20161204063113.13487.85583 () mimi ! kde ! org
[Download RAW message or body]
--===============0665618989360977589==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129601/#review101260
-----------------------------------------------------------
It looks good. I would reword it and change the signal from \
doubleClickedBesideItem() to something like doubleClickedNoItem() or even just \
doubleClicked(). The current wording makes me think that you have to double click \
beside an item and that the item has some significance, but really, you just have to \
double click anywhere but on an item.
- Don Nguyen
On Dec. 2, 2016, 11:36 a.m., Lorenz Haas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129601/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2016, 11:36 a.m.)
>
>
> Review request for Dolphin and KDE Usability.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> If you double click with the left mouse besides an item, you go up the folder \
> hierarchy.
> BUG: 307505
>
>
> Diffs
> -----
>
> src/dolphinmainwindow.cpp e5103fd
> src/kitemviews/kitemlistcontroller.h b8a93ed
> src/kitemviews/kitemlistcontroller.cpp 1c86ff0
> src/settings/dolphin_generalsettings.kcfg c724afc
> src/settings/navigation/navigationsettingspage.h 5410a4e
> src/settings/navigation/navigationsettingspage.cpp e37a35d
> src/views/dolphinview.h 0b0d819
> src/views/dolphinview.cpp 4105628
>
> Diff: https://git.reviewboard.kde.org/r/129601/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lorenz Haas
>
>
--===============0665618989360977589==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129601/">https://git.reviewboard.kde.org/r/129601/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It looks good. I would \
reword it and change the signal from doubleClickedBesideItem() to something like \
doubleClickedNoItem() or even just doubleClicked(). The current wording makes me \
think that you have to double click beside an item and that the item has some \
significance, but really, you just have to double click anywhere but on an \
item.</pre> <br />
<p>- Don Nguyen</p>
<br />
<p>On December 2nd, 2016, 11:36 a.m. UTC, Lorenz Haas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin and KDE Usability.</div>
<div>By Lorenz Haas.</div>
<p style="color: grey;"><i>Updated Dec. 2, 2016, 11:36 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If you double click with the left mouse besides an \
item, you go up the folder hierarchy.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">BUG: 307505</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dolphinmainwindow.cpp <span style="color: grey">(e5103fd)</span></li>
<li>src/kitemviews/kitemlistcontroller.h <span style="color: \
grey">(b8a93ed)</span></li>
<li>src/kitemviews/kitemlistcontroller.cpp <span style="color: \
grey">(1c86ff0)</span></li>
<li>src/settings/dolphin_generalsettings.kcfg <span style="color: \
grey">(c724afc)</span></li>
<li>src/settings/navigation/navigationsettingspage.h <span style="color: \
grey">(5410a4e)</span></li>
<li>src/settings/navigation/navigationsettingspage.cpp <span style="color: \
grey">(e37a35d)</span></li>
<li>src/views/dolphinview.h <span style="color: grey">(0b0d819)</span></li>
<li>src/views/dolphinview.cpp <span style="color: grey">(4105628)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129601/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0665618989360977589==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic