[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-usability
Subject:    Re: Review Request 129607: Display Application version in About dialog header
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2016-12-03 16:13:55
Message-ID: 20161203161355.23280.16797 () mimi ! kde ! org
[Download RAW message or body]

--===============0492889211802620860==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit



> On Dec. 3, 2016, 2:29 p.m., Sebastian Kügler wrote:
> > I understand the problem, but I don't like the duplication you're introducing \
> > with this patch: The version number is now on the screen two times when you open \
> > the versions tab, and also, why have a versions tab, when the version is already \
> > displayed.
> 
> Luigi Toscano wrote:
> Change "Version" tab to "Environment"?
> Merge Version into the main info tab (even if I have the feeling that this we \
> discussed)? 
> Martin Gräßlin wrote:
> I don't like the name "Environment". I would expect the env variables there
> 
> Luigi Toscano wrote:
> Sure, there are other options. "System details"? "Libraries" (and we could put the \
> poppler version for Okular, for example)? ...

> and we could put the poppler version for Okular

yeah, that was one of the ideas for having an API to adjust the version information.

I don't have a good idea for the name of the tab.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129607/#review101235
-----------------------------------------------------------


On Dec. 3, 2016, 2:39 p.m., Jean-Baptiste Mardelle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129607/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2016, 2:39 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and Sebastian Kügler.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> Last year, a change in kaboutapplicationdialog (review 124133) moved the \
> application version in a separate tab. However for applications, it is really \
> annoying (several Kdenlive users complained and I fully agree) to not have this \
> information clearly displayed as soon as the About dialog is displayed. I \
> understand the interest of having a separate version tab displaying the various \
> underlying libraries used, but I propose to display again the application version \
> in the About dialog header (see screenshot). 
> 
> Diffs
> -----
> 
> src/kaboutapplicationdialog.cpp 156410e 
> 
> Diff: https://git.reviewboard.kde.org/r/129607/diff/
> 
> 
> Testing
> -------
> 
> Reverts a recent change, tested and works.
> 
> 
> File Attachments
> ----------------
> 
> About dialog with version
> https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/c02f4767-2a74-4c25-8599-de410678867e__about.png
>  Updated patch
> https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/ee13cb47-2162-4be7-8255-3dce7f470c2b__about2.png
>  
> 
> Thanks,
> 
> Jean-Baptiste Mardelle
> 
> 


--===============0492889211802620860==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129607/">https://git.reviewboard.kde.org/r/129607/</a>
  </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On December 3rd, 2016, 2:29 p.m. CET, <b>Sebastian \
Kügler</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I understand the problem, but I don't like the \
duplication you're introducing with this patch: The version number is now on the \
screen two times when you open the versions tab, and also, why have a versions tab, \
when the version is already displayed.</p></pre>  </blockquote>




 <p>On December 3rd, 2016, 2:31 p.m. CET, <b>Luigi Toscano</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Change "Version" tab to "Environment"? Merge Version into the main info tab \
(even if I have the feeling that this we discussed)?</p></pre>  </blockquote>





 <p>On December 3rd, 2016, 5:06 p.m. CET, <b>Martin Gräßlin</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't like the name "Environment". I would expect the env variables there</p></pre>  \
</blockquote>





 <p>On December 3rd, 2016, 5:09 p.m. CET, <b>Luigi Toscano</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sure, \
there are other options. "System details"? "Libraries" (and we could put the poppler \
version for Okular, for example)? ...</p></pre>  </blockquote>








</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">and we could put the poppler version for Okular</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">yeah, that was one of the ideas for having an API to \
adjust the version information.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't have a good \
idea for the name of the tab.</p></pre> <br />










<p>- Martin</p>


<br />
<p>On December 3rd, 2016, 2:39 p.m. CET, Jean-Baptiste Mardelle wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, KDE Usability and Sebastian Kügler.</div>
<div>By Jean-Baptiste Mardelle.</div>


<p style="color: grey;"><i>Updated Dec. 3, 2016, 2:39 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kxmlgui
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Last year, a change in kaboutapplicationdialog (review \
124133) moved the application version in a separate tab. However for applications, it \
is really annoying (several Kdenlive users complained and I fully agree) to not have \
this information clearly displayed as soon as the About dialog is displayed. I \
understand the interest of having a separate version tab displaying the various \
underlying libraries used, but I propose to display again the application version in \
the About dialog header (see screenshot).</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Reverts a recent change, tested and works.</p></pre>  \
</td>  </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kaboutapplicationdialog.cpp <span style="color: grey">(156410e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129607/diff/" style="margin-left: \
3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/c02f4767-2a74-4c25-8599-de410678867e__about.png">About \
dialog with version</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/ee13cb47-2162-4be7-8255-3dce7f470c2b__about2.png">Updated \
patch</a></li>

</ul>




  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============0492889211802620860==--


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic