[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-usability
Subject:    Re: Review Request 128793: [kio_mtp] Improve warning message
From:       Elvis Angelaccio <elvis.angelaccio () kde ! org>
Date:       2016-11-03 13:21:20
Message-ID: 20161103132120.15339.57940 () mimi ! kde ! org
[Download RAW message or body]

--===============6391526782223474455==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128793/
-----------------------------------------------------------

(Updated Nov. 3, 2016, 1:21 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Changes
-------

Submitted with commit e5619efafdd9c316e6d3e609ddd73939dea3e270 by Elvis Angelaccio to \
branch master.


Repository: kio-extras


Description
-------

Sometimes the "Maybe you need to unlock your device?" message appears even if the \
user has unlocked their device, so it's not very useful. This happened to me as well \
and I had to look for [the \
fix](https://forums.opensuse.org/showthread.php/510787-android-phone-mtp-can-t-access-folders?p=2736133#post2736133) \
on google.

Since this warning is displayed also when MTP is disabled on the phone's side, let's \
warn the user about this.


Diffs
-----

  mtp/kio_mtp.cpp 8a9b26e 

Diff: https://git.reviewboard.kde.org/r/128793/diff/


Testing
-------


Thanks,

Elvis Angelaccio


--===============6391526782223474455==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128793/">https://git.reviewboard.kde.org/r/128793/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and KDE Usability.</div>
<div>By Elvis Angelaccio.</div>


<p style="color: grey;"><i>Updated Nov. 3, 2016, 1:21 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit e5619efafdd9c316e6d3e609ddd73939dea3e270 by Elvis \
Angelaccio to branch master.</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Sometimes the "Maybe you need to unlock your device?" \
message appears even if the user has unlocked their device, so it's not very useful. \
This happened to me as well and I had to look for <a \
href="https://forums.opensuse.org/showthread.php/510787-android-phone-mtp-can-t-access-folders?p=2736133#post2736133" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">the fix</a> on google.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Since this warning is \
displayed also when MTP is disabled on the phone's side, let's warn the user about \
this.</p></pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>mtp/kio_mtp.cpp <span style="color: grey">(8a9b26e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128793/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============6391526782223474455==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic