'Re: [KDE Usability] Review Request 128413: Add clipboard buttons in the Checksums tab'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-usability
Subject:    Re: [KDE Usability] Review Request 128413: Add clipboard buttons in the Checksums tab
From:       Michel Hermier <michel.hermier () gmail ! com>
Date:       2016-07-10 7:44:49
Message-ID: 20160710074449.8816.91580 () mimi ! kde ! org
[Download RAW message or body]

--===============1179189961256324748==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128413/#review97249
-----------------------------------------------------------

I don't see the point of this change. From a user perspective a user \
knowing what a hash is know how to use context menu to reach this panel and \
should be educated enought to know the copy/paste shortcuts. For me it is \
more interesting that when cliking on text it would select the whole hash \
text.

- Michel Hermier

On juil. 9, 2016, 7:55 après-midi, Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128413/
> -----------------------------------------------------------
> 
> (Updated juil. 9, 2016, 7:55 après-midi)
> 
> 
> Review request for KDE Frameworks, KDE Usability and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> As discussed in RR 128283, we can improve the usability of the dialog if \
> we add buttons to interact with the clipboard. 
> The Paste button is always visible, while the three Copy buttons are \
> hidden until the correspoding checksum is computed. 
> 
> Diffs
> -----
> 
> src/widgets/checksumswidget.ui 03c64db 
> src/widgets/kpropertiesdialog.cpp 808765c 
> 
> Diff: https://git.reviewboard.kde.org/r/128413/diff/
> 
> 
> Testing
> -------
> 
> Copy/Paste works as expected.
> 
> 
> File Attachments
> ----------------
> 
> Paste button next to the input field.
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/906d90f6-7727-4163-9992-c688667073ec__Spectacle.J11500.png
>  Example of Copy button
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/10c18534-0e72-4c8c-98ae-144a909438c9__Spectacle.J11519.png
>  
> 
> Thanks,
> 
> Elvis Angelaccio
> 
> 

--===============1179189961256324748==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128413/">https://git.reviewboard.kde.org/r/128413/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I don't see the point of this \
change. From a user perspective a user knowing what a hash is know how to \
use context menu to reach this panel and should be educated enought to know \
the copy/paste shortcuts. For me it is more interesting that when cliking \
on text it would select the whole hash text.</p></pre>  <br />

<p>- Michel Hermier</p>

<br />
<p>On juillet 9th, 2016, 7:55 après-midi UTC, Elvis Angelaccio wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, KDE Usability and David \
Faure.</div> <div>By Elvis Angelaccio.</div>

<p style="color: grey;"><i>Updated juil. 9, 2016, 7:55 après-midi</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">As discussed in RR 128283, we \
can improve the usability of the dialog if we add buttons to interact with \
the clipboard.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The Paste button is always \
visible, while the three Copy buttons are hidden until the correspoding \
checksum is computed.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Copy/Paste works as \
expected.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/widgets/checksumswidget.ui <span style="color: \
grey">(03c64db)</span></li>

 <li>src/widgets/kpropertiesdialog.cpp <span style="color: \
grey">(808765c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128413/diff/" \
style="margin-left: 3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File \
Attachments </h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/906d90f6-7727-4163-9992-c688667073ec__Spectacle.J11500.png">Paste \
button next to the input field.</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/10c18534-0e72-4c8c-98ae-144a909438c9__Spectacle.J11519.png">Example \
of Copy button</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1179189961256324748==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability

[prev in list] [next in list] [prev in thread] [next in thread] 